Skip to content

Add pnorm threshold for voting #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Add pnorm threshold for voting #1

merged 3 commits into from
Apr 26, 2024

Conversation

davidfee5
Copy link
Collaborator

This PR adds an optional network voting probability threshold to reduce low confidence classifications. Only applied to the network vote classifications at this point.

@davidfee5 davidfee5 added the enhancement New feature or request label Apr 26, 2024
@davidfee5 davidfee5 requested a review from darren-tpk April 26, 2024 05:40
@davidfee5 davidfee5 self-assigned this Apr 26, 2024
davidfee5 and others added 2 commits April 25, 2024 21:51
pnorm_thresh is set to lowercase for now, PEP8 overhaul in a separate commit/PR
@darren-tpk
Copy link
Owner

darren-tpk commented Apr 26, 2024

Changes to toolbox.py look good to me.

PNORM_THRESH argument wasn't fed into check_timeline in timeline_checker.py. So I made some changes in the example script. I also note that the example script currently doesn't follow PEP8 recommendations, I'll table that for a separate commit. For now PNORM_THRESH is changed to pnorm_thresh to match the other input args. Will overhaul for PEP8 style later

@darren-tpk darren-tpk merged commit cd393c8 into main Apr 26, 2024
@davidfee5 davidfee5 deleted the pnorm branch June 10, 2024 13:42
davidfee5 pushed a commit that referenced this pull request Apr 15, 2025
Add pnorm threshold for voting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants