-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for camera back "Hasselblad CFV-50c" (100% equivalent to the H5D-50c) #622
Added support for camera back "Hasselblad CFV-50c" (100% equivalent to the H5D-50c) #622
Conversation
…o the H5D-50c) Added camera back "Hasselblad CFV-50c" which is completely equivalent to the "Hasselblad H5D-50c" (also tested by changing camera model on exif file from H5D-50c to CFV-50c).
Is this the same camera as |
I don't think so. EXIF camera model on CFV-50c FFF raw files says "Hasselblad CFV-50c" and not "Hasselblad CFV-50c/200". Such raw files don't load on Darktable. If I change the EXIF camera model with an exif editor to "Hasselblad H5D-50c" the raw files is loaded correctly on Darktable. Honestly, I don't think a camera model named "Hasselblad CFV-50c/200" even exist(ed) on Hasselblad portfolio. I did not load any example up until now. If needed, where do I have to upload sample RAW files? |
I see. Then please contribute the full sample set to https://raw.pixls.us/ |
Also, please be sure to upload the file manually copied straight from the card, @mristuccia thank you! |
Sure! Just uploaded. Hope this is what you need. |
@mristuccia thank you for contributing the sample! @mristuccia thank you! |
@LebedevRI thank you for the support. |
Well, if you can build dt yourself, you just need to update the |
I'd much rather we went w/ aliases for Hasselblads like we did in #621 etc. Only not clear if this should be an alias for H5D-50c or X1D... Also note that the model string usually changes depending whether it is the .3FR raw from the card directly or .FFF raw via Phocus software tethered transfer. This PR and the uploaded sample only cover the .FFF option. |
Definitely not the X1D. X1D is more the equivalent of the CFV-50c Mk II (or vice versa).
3FR files cannot be edited in the standard Hasselblad Phocus RAW developer, they need to be imported to be edited. The import procedure turns them into FFFs, which soon after the import/tether are still considered untouched originals. |
I mean, it's not like things are set in stone afterwards.
I guess, you need to take the https://raw.pixls.us/getfile.php/7199/nice/Hasselblad%20-%20Hasselblad%20CFV-50c%20-%2016bit%20(4:3).fff, import into whatever software, and then upload the resulting "imported" "raw" again to RPU, |
CVF II 50C is based on X1D II 50C AFAICT, not the original X1D. But all three seem to have the same sensor.
Thanks for the background!
Oh, you'd still see them as separate models in darktable, it's just that internal technical debt in maintaining rawspeed database, dt noise profiles etc. is reduced.
AFAICT this is more of an recommendation than a rule. Adobe Camera Raw certainly lists 3FR as supported for example, and we seem to have no problem loading either 3FR or FFF for the supported models in rawspeed and dt. For starters, it would be good to also upload the 3FR that was the source for the the FFF you have already uploaded (or upload a new matching pair). @LebedevRI I think the other |
So, if your 3FR comes out as diff --git a/data/cameras.xml b/data/cameras.xml
index 569bd69d..b557bb7d 100644
--- a/data/cameras.xml
+++ b/data/cameras.xml
@@ -17286,6 +17286,11 @@
</CFA>
<Crop x="56" y="104" width="-56" height="0"/>
<Sensor black="256" white="62914"/>
+ <Aliases>
+ <Alias id="CFV-50c">Hasselblad CFV-50c</Alias>
+ <Alias id="CFV-50c">Hasselblad CFV-50c/200</Alias>
+ <Alias id="CFV-50c">Hasselblad CFV-50c/500</Alias>
+ </Aliases>
<ColorMatrices>
<ColorMatrix planes="3">
<ColorMatrixRow plane="0">4932 -835 141</ColorMatrixRow>
@@ -17294,24 +17299,6 @@
</ColorMatrix>
</ColorMatrices>
</Camera>
- <Camera make="Hasselblad" model="Hasselblad CFV-50c">
- <ID make="Hasselblad" model="CFV-50c">Hasselblad 50-15-Coated5</ID>
- <CFA width="2" height="2">
- <Color x="0" y="0">RED</Color>
- <Color x="1" y="0">GREEN</Color>
- <Color x="0" y="1">GREEN</Color>
- <Color x="1" y="1">BLUE</Color>
- </CFA>
- <Crop x="56" y="104" width="-56" height="0"/>
- <Sensor black="256" white="62914"/>
- <ColorMatrices>
- <ColorMatrix planes="3">
- <ColorMatrixRow plane="0">4932 -835 141</ColorMatrixRow>
- <ColorMatrixRow plane="1">-4878 11868 3437</ColorMatrixRow>
- <ColorMatrixRow plane="2">-1138 1961 7067</ColorMatrixRow>
- </ColorMatrix>
- </ColorMatrices>
- </Camera>
<Camera make="Hasselblad" model="Flash Sync">
<ID make="Hasselblad" model="CF132">Hasselblad 22-Uncoated</ID>
<CFA width="2" height="2"> |
@LebedevRI Maybe add a "Hasselblad: Both 3FR and FFF" note on RPU front page as well ? |
Btw, looks like that older |
Yes, it doesn't decode as uncompressed either. I've deleted it. |
|
Hm, didn't have access to the uncompressed one... The ljpeg failure could be perhaps also related to #144? I was getting this:
and I can also reproduce it on H5D-50c 3FR samples from DPR (maybe one more hint this is indeed the same sensor+processor as in CFV-50c). |
@kmilos there is an error in the alias: the id must be corrected as indicated here below. And, by the way, I was able to identify all aliases for the .3FR files generated by the CFV-50c:
@kmilos if you want you can add all of them as well. This will guarantee the 3FR compatibility in addition to the FFF one. I have this digital back and I've understood where the information after the "/" is coming from. Those are the different camera systems this back is compatible with and they can be chosen from its settings menu. I remain sceptic on the fact that editing a 3FR is not intended by design by Hasselblad though. |
Define "editing"? I guess the question is, what modifications are done to the decoded 3FR before it is re-saved as FFF? |
Phocus, the official Hasselblad RAW editor, does not allow to do apply any development to the 3FR file. Only conversion to FFF is possible. So any action that causes the creation of a sidecar .xmp file to the 3FR should be avoided if we want to stick to the original Vendor's intent. |
That does not, at all, mean that no changes are done to the data.
Well, that is rather, err, . The vendor's intent is for consumers |
Anyway, I'm not able to open the 3FR files despite all the alias are there and despite I've double checked the model name directly from the EXIF data. So, there is something in the 3FR files that is going against your desire not to think about the vendor intent too much. 😅 |
Which 3FR in particular? |
The inability to open 3FR files for these older models is not due to aliases, but entirely due to #144 3FR files from newer models like CFV II 50C and X1D 50C II open just fine. When converting to FFF, this is (losslessly again) re-compressed to a more compliant stream for one. We don't know if there is any other processing on top. |
Any 3FR coming from my CFV-50c (mark I).
The model name in the alias is correct, so most probably it is the #144. For now I'll stick with the process of generating the FFF file by importing the 3FR in Phocus and then I'll develop the FFF file on Darkroom. |
@mristuccia Could you please one of the problematic(!!!) raws, Bonus points if the sample is well-lit (low-iso daylight landscape) and is horizontal. |
Done.
Now, where are my bonus points? 😀 |
P.S. But even including such leading blank character in the alias it does not work. |
I think we want to remove the part after the / in the |
And I really think we want #650 |
Sure, makes sense if you're looking for ultimate color accuracy as Hasselblad defines it. But if it really is just a R/B calibration, one should be able to easily corrected for in post in dt, so no reason not to try and enable 3FR support in dt and let people get creative either way! |
Sure, to each his own. Freedom is freedom! 😊 |
FWIW, |
Added camera back "Hasselblad CFV-50c" which is completely equivalent to the "Hasselblad H5D-50c" (also tested by changing camera model on exif file from H5D-50c to CFV-50c).