Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 45x35 portrait aspect ratio to crop module #17970

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

da-phil
Copy link
Contributor

@da-phil da-phil commented Dec 8, 2024

Add the popular 45x35 aspect ratio to the crop module.
This aspect ratio is also used for IDs and passports.

@da-phil
Copy link
Contributor Author

da-phil commented Dec 8, 2024

Can anybody shed some light on how to update the PO files to add this new translatable string? Maybe @ralfbrown or @TurboGit?
Which also brings me to the related question if this how-to is still up-to-date: https://github.com/darktable-org/darktable/blob/master/doc/TRANSLATORS.md

@ralfbrown
Copy link
Collaborator

What you did is exactly what is needed - after merging into master, the next time the translation files are updated, the new string inside _("") will be added to the PO files and the translators can then translate it.

@ralfbrown ralfbrown added scope: translation / strings make darktable international scope: UI user interface and interactions labels Dec 8, 2024
@TurboGit TurboGit added this to the 5.2 milestone Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: translation / strings make darktable international scope: UI user interface and interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants