dnet: add additional check to prevent logic error

also remove unnecessary nesting
darkrenaissance · Nov 12, 2023 · 6bf00e5 · 6bf00e5
1 parent b94b6fb
commit 6bf00e5
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/bin/dnet/view.py b/bin/dnet/view.py
@@ -286,21 +286,23 @@ def events(self, nodes):
                 self.fill_right_box()
 
                 if 'inbound' in info:
+                    # New inbound online.
                     for key in info['inbound'].keys():
-                        # New inbound online.
                         if key not in self.known_inbound:
                             addr = info['inbound'].get(key)
-                            if bool(addr):
-                                logging.debug(f"Refresh: inbound {key} online")
-                                self.refresh = True
-                        # Known inbound offline.
-                        for key in self.known_inbound:
-                            addr = info['inbound'].get(key)
-                            if bool(addr):
+                            if not bool(addr) or not addr == None:
                                 continue
-                            logging.debug(f"Refresh: inbound {key} offline")
+                            logging.debug(f"Refresh: inbound {key} online")
                             self.refresh = True
 
+                    # Known inbound offline.
+                    for key in self.known_inbound:
+                        addr = info['inbound'].get(key)
+                        if bool(addr) or addr == None:
+                            continue
+                        logging.debug(f"Refresh: inbound {key} offline")
+                        self.refresh = True
+
                 # New outbound online.
                 if 'outbound' in info:
                     for i, info in info['outbound'].items():