Merge pull request #504 from mkht/issue503

Improve VerbosePreference and Verbose switch behavior.
darkoperator · Jun 5, 2024 · ba95131 · ba95131
2 parents 1c745f4 + 51f13d6
commit ba95131
Showing 1 changed file with 18 additions and 2 deletions.
diff --git a/Source/PoshSSH/PoshSSH/NewSessionBase.cs b/Source/PoshSSH/PoshSSH/NewSessionBase.cs
@@ -190,8 +190,24 @@ protected override void BeginProcessing()
         }
         protected BaseClient CreateConnection(string computer)
         {
-            var isVerboseEnabled = MyInvocation.BoundParameters.ContainsKey("Verbose") ||
-                (ActionPreference)this.SessionState.PSVariable.GetValue("VerbosePreference") != ActionPreference.SilentlyContinue;
+            var isVerboseEnabled = MyInvocation.BoundParameters.ContainsKey("Verbose");
+            if (!isVerboseEnabled)
+            {
+                switch (this.SessionState.PSVariable.GetValue("VerbosePreference"))
+                {
+                    case ActionPreference apVp:
+                        isVerboseEnabled = (apVp != ActionPreference.SilentlyContinue);
+                        break;
+
+                    case string strVp:
+                        isVerboseEnabled = Enum.TryParse<ActionPreference>(strVp, true, out ActionPreference vp) &&
+                         (vp != ActionPreference.SilentlyContinue);
+                        break;
+
+                    default:
+                        break;
+                }
+            }
 
             ConnectionInfo connectInfo = null;
             switch (ParameterSetName)