Sound Manager to master #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in ums as pointer to object not string). Work in progress with soundGroup
…, observer pattern in SoundGroup
…o audio to clip, fix bugs
skay44
reviewed
Apr 11, 2025
src/sound/manager.cpp
Outdated
| void SoundManager::removeClip(std::shared_ptr<SoundClip> sc) { | ||
| removeFromVector(v_clips, sc); | ||
| if (sc) { | ||
| sc->~SoundClip(); |
magistermaks
requested changes
Apr 11, 2025
src/sound/manager.cpp
Outdated
| void SoundManager::removeClip(std::shared_ptr<SoundClip> sc) { | ||
| removeFromVector(v_clips, sc); | ||
| if (sc) { | ||
| sc->~SoundClip(); |
src/sound/manager.cpp
Outdated
| } | ||
|
|
||
| void SoundManager::removeGroup(std::weak_ptr<SoundGroup> sc) { | ||
| sc.lock()->~SoundGroup(); |
src/sound/source.cpp
Outdated
|
|
||
| void SoundSourceObject::initSource(int number_of_sources){ | ||
| alGetError(); | ||
| this->number_of_sources = number_of_sources; |
There was a problem hiding this comment.
if there are no plans to use this "number of sounds" please remove it
src/sound/source.cpp
Outdated
| // SoundSourceObject constructor to create object with only one sound source | ||
|
|
||
| SoundSourceObject::SoundSourceObject(){ | ||
| SoundSourceObject::initSource(1); |
There was a problem hiding this comment.
also, i guess, just inline the initSource() function in here
src/sound/source.cpp
Outdated
| } | ||
|
|
||
| void SoundSourceObject::stop(int source_number) { | ||
| if (source_number > this->number_of_sources || !alIsSource(this->sso_sources[source_number])) { |
There was a problem hiding this comment.
eeee, make is so that SSOs are always valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.