Skip to content

Sound Manager to master #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
May 21, 2025
Merged

Sound Manager to master #22

merged 36 commits into from
May 21, 2025

Conversation

Wiesiek418
Copy link
Collaborator

No description provided.

@Wiesiek418
OpenAL cmake config
d815b88
@Wiesiek418
Constructors, Destructors [Sound, Source, Clip] and SoundListener
1f5c995
@Wiesiek418
Load audio file OGG
0928d0c
@Wiesiek418
Fix code format
5bb0282
@Wiesiek418
Commit for test raytrace
47b5eff
@Wiesiek418
Rebuild Sound Manager and playing sound
ee5c287
@Wiesiek418
Pause, Stop sound. Comments in manager
e675d64
@Wiesiek418
Delete sound thread
b22e01f
@Wiesiek418
Changing the ums_sources parameter from sso name to sso object and ad…
4b877ea 
…ded SourceGroup
@Wiesiek418
Refactore and rebuild manager, soundClip, soundSource (soundClip key …
6b8063e 
…in ums as pointer to object not string). Work in progress with soundGroup
@Wiesiek418
Rebuild of sound manager (WiP), change map to vector, shared/weak poi…
f151877 
…nters
@Wiesiek418
Fix sound debug, detect expired pointer
19a4cdc
@Wiesiek418
Replace throw to cerr in source, manager, clip
dc90250
@Wiesiek418
External public function from manager.cpp to functions.hpp and WiP gr…
8e920eb 
…oup.hpp
@Wiesiek418
Delete SoundGroupParameters and SoundGroupMovement, add functions.hpp…
634be22 
…, observer pattern in SoundGroup
@Wiesiek418
Sound group as a offset in sso, adds all parameters, getting only mon…
d1b951c 
…o audio to clip, fix bugs
@Wiesiek418
Fast commit before branch engine test
c48d3b3
@Wiesiek418
Comments on sound hpp files
6f2a24f
@Wiesiek418
WiP load WAV file, add removeObject to SoundManager
3f7a659
@Wiesiek418
Merge master to sound
3182ba2
skay44
skay44 reviewed Apr 11, 2025
View reviewed changes
magistermaks
magistermaks requested changes Apr 11, 2025
View reviewed changes
magistermaks
magistermaks requested changes Apr 26, 2025
View reviewed changes
Copy link
Member

@magistermaks magistermaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some further issues, there are some memory leaks I found.
Also would be nice to pass some of the std::shared_ptrs as const refs
to not copy them everywhere

skay44
skay44 requested changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@skay44 skay44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck

magistermaks
magistermaks approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@magistermaks magistermaks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are on track here, some minor issues

@magistermaks
Copy link
Member

@Wiesiek418
As master was just updated please merge the new changes

@magistermaks magistermaks merged commit c4231ed into master May 21, 2025
@magistermaks magistermaks deleted the sound branch May 21, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skay44 skay44 skay44 approved these changes

@MateuszTk MateuszTk MateuszTk approved these changes

@magistermaks magistermaks magistermaks approved these changes

@1Tymon1 1Tymon1 1Tymon1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Wiesiek418 @magistermaks @skay44 @MateuszTk @1Tymon1