Added distributed lock API #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zachary Edgell <[email protected]>
Signed-off-by: Zachary Edgell <[email protected]>
Signed-off-by: Zachary Edgell <[email protected]>
Signed-off-by: Zachary Edgell <[email protected]>
mikeee
reviewed
Mar 28, 2024
Comment on lines
+459
to
+475
| /// Distributed lock request call | ||
| /// | ||
| /// # Arguments | ||
| /// | ||
| /// * `request` - Request to be made, TryLockRequest | ||
| pub async fn lock(&mut self, request: TryLockRequest) -> Result<TryLockResponse, Error> { | ||
| self.0.lock(request).await | ||
| } | ||
|
|
||
| /// Distributed lock request call | ||
| /// | ||
| /// # Arguments | ||
| /// | ||
| /// * `request` - Request to be made, TryLockRequest | ||
| pub async fn unlock(&mut self, request: UnlockRequest) -> Result<UnlockResponse, Error> { | ||
| self.0.unlock(request).await | ||
| } |
There was a problem hiding this comment.
I think it would be beneficial to have examples here in the doc comments of building and using the api call e.g.
/// # Example
///
/// ```
/// let result = client
/// .try_lock(dapr::client::TryLockRequest {
/// store_name: "lockstore".to_string(),
/// resource_id: "resource".to_string(),
/// lock_owner: "owner".to_string(),
/// expiry_in_seconds: 60,
/// })
/// .await
/// .unwrap();
/// ```
mikeee
reviewed
Mar 28, 2024
Signed-off-by: Mike Nguyen <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]> Signed-off-by: Zachary K Edgell <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]> Signed-off-by: Zachary K Edgell <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]> Signed-off-by: Zachary K Edgell <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]>
mikeee
requested changes
May 6, 2024
There was a problem hiding this comment.
We can create another issue to track adding documentation but before a final review the APIs need to be defined in the interface -> https://github.com/dapr/rust-sdk/pull/159/files#diff-7f93c4e263c4e9ec748f804c7fd04a3b2fde86ffd741fb5516d67e1097bae4c1L545
|
This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added distributed lock API
Issue reference
This PR will close #86
Checklist