-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Dapr Crypto .NET Quickstart #1132
base: release-1.15
Are you sure you want to change the base?
Conversation
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…uickstart-crypto-dotnet
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @WhitWaldo!! Same comments on this one:
- remove the python sdk commits,
- sign your commits
- Ensure similarity with the other crypto quickstarts
Same issue as the other - the python commit showed up when I targeted dapr:release-1.15 as it's not on my local branch. Again, should I be targeting a different branch to merge into? I didn't realize I missed a commit. I'll circle back on that one. This is the one project I actually read the other quickstarts and I didn't like them as much so I went in another direction. Why would anyone encrypt an image? It made more sense to me to offer practical examples that demonstrated several different techniques offered by the SDK:
I also considered adding a large-file version generated at runtime (so as not to add to the tree) that demonstrates the bidirectional streaming capability inherent to the SDK (not as easily done with HTTP) as it's been an ask several times for support greater than 4 GB. |
Description
Added quickstart demonstrating the use of the Dapr Crypto API showing encryption and decryption for both strings and file streams.
Issue reference
N/A - part of 1.15 endgame
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: