Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate_tutorials #1069

Merged
merged 5 commits into from
Jul 25, 2024
Merged

fix: validate_tutorials #1069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
323853b
chore: rename workflow, bump kubernetes versions and print redis logs
mikeee Jul 25, 2024
ff7603a
ci: remove debug/log step
mikeee Jul 25, 2024
231fb83
fix: define resiliency policy
mikeee Jul 25, 2024
afdd5ea
fix: update expected validation output
mikeee Jul 25, 2024
4d9be49
fix: add sleep/background arguments to the observability tutorial
mikeee Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/validate.yaml → .github/workflows/validate_tutorials.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ jobs:
runs-on: ${{ matrix.os }}
timeout-minutes: 40
env:
GOVER: 1.17
KUBERNETES_VERSION: v1.21.1
KIND_VERSION: v0.12.0
KIND_IMAGE_SHA: sha256:69860bda5563ac81e3c0057d654b5253219618a22ec3a346306239bba8cfa1a6
GOVER: 1.22
KUBERNETES_VERSION: v1.29.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modern kubernetes and kind versions. check!

KIND_VERSION: v0.23.0
KIND_IMAGE_SHA: sha256:3abb816a5b1061fb15c6e9e60856ec40d56b7b52bcea5f5f1350bc6e2320b6f8
strategy:
matrix:
os: [ubuntu-latest]
Expand Down
2 changes: 1 addition & 1 deletion tutorials/hello-kubernetes/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ To call the service that you set up port forwarding to, from a command prompt ru
<!-- STEP
name: Curl Test
expected_stdout_lines:
- '{"DAPR_HTTP_PORT":"3500","DAPR_GRPC_PORT":"50001"}'
- '{"DAPR_HTTP_ENDPOINT":"http://localhost:3500","DAPR_GRPC_ENDPOINT":"http://localhost:50001"}'
tags:
- normal-run
-->
Expand Down
4 changes: 3 additions & 1 deletion tutorials/hello-kubernetes/dapr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
version: 1
common:
resourcesPath: ./resources
apps:
- appDirPath: ./node
appID: nodeapp
Expand All @@ -7,4 +9,4 @@ apps:
createService: true
- appDirPath: ./python
appID: pythonapp
containerImage: ghcr.io/dapr/samples/hello-k8s-python:latest
containerImage: ghcr.io/dapr/samples/hello-k8s-python:latest
8 changes: 8 additions & 0 deletions tutorials/hello-kubernetes/resources/resiliency.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
spec:
policies:
retries:
# Global Retry Policy
DefaultRetryPolicy:
policy: constant
duration: 1s
maxRetries: -1
3 changes: 3 additions & 0 deletions tutorials/observability/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,8 @@ expected_stdout_lines:
- '"total":"54"'
output_match_mode: substring
name: "Curl test"
background: false
sleep: 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this makes more resilient for timing issues in the runner

-->

```bash
Expand Down Expand Up @@ -476,6 +478,7 @@ output_match_mode: substring
expected_stderr_lines:

name: Curl validate
background: false
-->

```bash
Expand Down
Loading