-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jobs API Quickstarts #1064
Jobs API Quickstarts #1064
Conversation
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please just unique-ify ports in /sdk/* version of dapr.yaml (and matching go file if needed). then we're good.
|
||
fmt.Println("Job Scheduled:", jobName) | ||
|
||
time.Sleep(5 * time.Second) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider removing these. but for now if stable leave them. I think it confuses to have sleeps here in code, also in MMD readme.
Signed-off-by: Fernando Rocha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thank you for this quickstart @rochabr !
Golang check fails only on SDK, which you warned me and we knew about. Please collab with @cicoyle here why this is happening. Meanwhile I will approve and merge change so we can make progress using Http and partial sdk. Nice work here! |
@holopin-bot @rochabr Thank you Fernando! 🙏 |
Congratulations @rochabr, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzwiho9e44430cjvv2hld79c This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Description
Including SDK and HTTP quickstart examples in Go for the Jobs API.
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1026
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: