Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobs API Quickstarts #1064

Merged
merged 10 commits into from
Jul 25, 2024
Merged

Jobs API Quickstarts #1064

merged 10 commits into from
Jul 25, 2024

Conversation

rochabr
Copy link
Contributor

@rochabr rochabr commented Jul 24, 2024

Description

Including SDK and HTTP quickstart examples in Go for the Jobs API.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1026

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr rochabr changed the title Jobs api Jobs API Quickstarts Jul 24, 2024
jobs/go/http/README.md Outdated Show resolved Hide resolved
jobs/go/http/README.md Show resolved Hide resolved
Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@paulyuk paulyuk added this to the 1.14 milestone Jul 24, 2024
@paulyuk paulyuk added P1 area/jobs enhancement New feature or request labels Jul 24, 2024
@rochabr rochabr changed the base branch from master to release-1.14 July 25, 2024 07:46
Signed-off-by: Fernando Rocha <[email protected]>
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please just unique-ify ports in /sdk/* version of dapr.yaml (and matching go file if needed). then we're good.

.github/env/global.env Show resolved Hide resolved
jobs/go/http/dapr.yaml Show resolved Hide resolved

fmt.Println("Job Scheduled:", jobName)

time.Sleep(5 * time.Second)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider removing these. but for now if stable leave them. I think it confuses to have sleeps here in code, also in MMD readme.

jobs/go/sdk/dapr.yaml Outdated Show resolved Hide resolved
Signed-off-by: Fernando Rocha <[email protected]>
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you for this quickstart @rochabr !

@paulyuk paulyuk merged commit be70bef into dapr:release-1.14 Jul 25, 2024
4 of 7 checks passed
@paulyuk
Copy link
Contributor

paulyuk commented Jul 25, 2024

Golang check fails only on SDK, which you warned me and we knew about. Please collab with @cicoyle here why this is happening.

Meanwhile I will approve and merge change so we can make progress using Http and partial sdk. Nice work here!

@marcduiker
Copy link
Contributor

@holopin-bot @rochabr Thank you Fernando! 🙏

Copy link

holopin-bot bot commented Aug 16, 2024

Congratulations @rochabr, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzwiho9e44430cjvv2hld79c

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jobs enhancement New feature or request P1
Projects
Development

Successfully merging this pull request may close these issues.

Go SDK and Go Http Quickstart for Jobs API
4 participants