Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix distributed calculator tutorial Go docker build #1058

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Fix distributed calculator tutorial Go docker build #1058

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99e07f1
Fix distributed calculator tutorial Go docker build
antontroshin Jul 23, 2024
c2a7d3f
CR fix, use latest debian container
antontroshin Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions tutorials/distributed-calculator/go/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
#first stage - builder
FROM golang:1.15-buster as builder
FROM golang:1.19-buster as builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM golang:1.19-buster as builder
FROM golang:1.22-bullseye as builder

What if we go straight to supported version 1.22 on bullseye so long as there's no breaking changes? Feels like being on latest supported is what we want if we're changing this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I fully agree. I was playing safe with 1.19.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok since it's testing ok, let's go with the 1.22, bullseye and bookworm changes. Are you ok with updating your PR for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used the same bookworm version for both build and run containers.

WORKDIR /dir
COPY app.go .
RUN go get -d -v
COPY app.go go.mod go.sum ./
RUN CGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo -o app .
#second stage
FROM debian:buster-slim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM debian:buster-slim
FROM debian:bookworm-slim

Similar idea. how about we do bookworm instead so we're on latest supported/patched?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note I tested your suggestion and my suggested changes and both work at runtime and are compatible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, glad to hear it worked. Thanks for testing it.

Expand Down
Loading