Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobs API Quickstarts #1056

Closed
wants to merge 80 commits into from
Closed

Jobs API Quickstarts #1056

wants to merge 80 commits into from

Conversation

rochabr
Copy link
Contributor

@rochabr rochabr commented Jul 22, 2024

Description

Including SDK and HTTP quickstart examples in Go for the Jobs API.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1026

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • [X]XYou've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

jobs/go/http/README.md Outdated Show resolved Hide resolved
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial look - haven't reviewed any of the unrelated changes to the jobs api.

.github/env/global.env Outdated Show resolved Hide resolved
.github/env/global.env Outdated Show resolved Hide resolved
jobs/go/http/README.md Show resolved Hide resolved
jobs/go/http/job-service/job-service.go Outdated Show resolved Hide resolved
jobs/go/http/job-service/job-service.go Outdated Show resolved Hide resolved
jobs/go/sdk/README.md Outdated Show resolved Hide resolved
jobs/go/sdk/README.md Show resolved Hide resolved
jobs/go/sdk/job-service/job-service.go Outdated Show resolved Hide resolved
jobs/go/sdk/job-service/job-service.go Outdated Show resolved Hide resolved
jobs/go/sdk/job-service/job-service.go Outdated Show resolved Hide resolved
salaboy and others added 26 commits July 23, 2024 08:19
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
…on 1.13 -> 1.14

Signed-off-by: Paul Yuknewicz <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
…o latest.

docs: Updated read me files to use Java 17 as baseline
Signed-off-by: amardeep2006 <[email protected]>

Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
rochabr and others added 20 commits July 23, 2024 12:20
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
…on 1.13 -> 1.14

Signed-off-by: Paul Yuknewicz <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
…o latest.

docs: Updated read me files to use Java 17 as baseline
Signed-off-by: amardeep2006 <[email protected]>

Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
* Update tutorials pub-sub csharp-subscriber image to dotnet 8.0

Signed-off-by: Anton Troshin <[email protected]>

* Update Dockerfile

Signed-off-by: Artur Souza <[email protected]>

---------

Signed-off-by: Anton Troshin <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
Co-authored-by: Artur Souza <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
rochabr and others added 2 commits July 23, 2024 12:52
Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
1. Open a terminal and run the `job-service` app:

```bash
dapr run --app-id job-service --app-port 6200 --dapr-http-port 6280 --dapr-grpc-port 6281 --app-protocol grpc -- go run .
Copy link
Member

@msfussell msfussell Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need these settings ?
--dapr-http-port 6280 --dapr-grpc-port 6281 --app-protocol grpc
And if only grpc, then why provide the HTTP one?

Can you have this instead?
dapr run --app-id job-service --app-port 6200 -- go run .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the grpc protocol is handling the job callback when it is triggered. what we don't need is the http port, really. I'll remove it.

Signed-off-by: Fernando Rocha <[email protected]>
Signed-off-by: Fernando Rocha <[email protected]>
@rochabr rochabr closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go SDK and Go Http Quickstart for Jobs API
8 participants