-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes data argument optional on transactional delete #752
Conversation
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix type check
tox -e type
tox -e mypy
Signed-off-by: Elena Kolevska <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
==========================================
- Coverage 86.63% 86.03% -0.60%
==========================================
Files 84 87 +3
Lines 4473 4783 +310
==========================================
+ Hits 3875 4115 +240
- Misses 598 668 +70 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Fixed. Thanks @berndverst |
Description
This PR makes the
data
parameter not required inTransactionalStateOperation
forDELETE
operations.Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Release Note
RELEASE NOTE: FIX Makes data argument optional on transactional delete