-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): add support to release dev packages #493
chore(release): add support to release dev packages #493
Conversation
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #493 +/- ##
==========================================
- Coverage 38.74% 36.72% -2.02%
==========================================
Files 82 82
Lines 8187 9927 +1740
Branches 371 371
==========================================
+ Hits 3172 3646 +474
- Misses 4956 6222 +1266
Partials 59 59
|
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me! Question: don't we want to use the commit sha hash instead of a timestamp?
Good idea, I think SHA will be helpful when users want to associate dev release with a commit - I had kept timestamps only for one reason, easy to find the latest version and based on time. Let me add a go style versioning in that case. e.g. 3.0.1-20230526200301-0744d001aa84 WDYT @XavierGeerinck? |
I would personally just do the sha hash :) |
Signed-off-by: Shubham Sharma <[email protected]>
861fd8f
Since short hashes can have collisions, we should either use
|
Good point, ok then we can use your proposal |
4440fdf
to
861fd8f
Compare
* Refactor current build and publish steps Signed-off-by: Shubham Sharma <[email protected]> * Move npm install to correct place Signed-off-by: Shubham Sharma <[email protected]> * Add dev publish steps Signed-off-by: Shubham Sharma <[email protected]> * Add package details to README Signed-off-by: Shubham Sharma <[email protected]> * Shared node_ver env; Signed-off-by: Shubham Sharma <[email protected]> * Revert matrix Signed-off-by: Shubham Sharma <[email protected]> * Use commit hash in version Signed-off-by: Shubham Sharma <[email protected]> --------- Signed-off-by: Shubham Sharma <[email protected]> Signed-off-by: jriffs <[email protected]>
Description
This PR refactors the build pipelines and adds a job to release dev packages (on push to main).
build-ci
to build typescript package without linting or prettifyingIssue reference
Please reference the issue this PR will close: #492
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: