Fix Configuration GRPC calls not sending metadata

Signed-off-by: Trevor Lund <[email protected]>
dapr · Feb 9, 2024 · 31d22f5 · 31d22f5
1 parent 5c2b40a
commit 31d22f5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/implementation/Client/GRPCClient/configuration.ts b/src/implementation/Client/GRPCClient/configuration.ts
@@ -28,7 +28,7 @@ import { SubscribeConfigurationResponse as SubscribeConfigurationResponseResult
 import { SubscribeConfigurationCallback } from "../../../types/configuration/SubscribeConfigurationCallback";
 import { SubscribeConfigurationStream } from "../../../types/configuration/SubscribeConfigurationStream";
 import { ConfigurationItem } from "../../../types/configuration/ConfigurationItem";
-import { createConfigurationType } from "../../../utils/Client.util";
+import { addMetadataToMap, createConfigurationType } from "../../../utils/Client.util";
 
 export default class GRPCClientConfiguration implements IClientConfiguration {
   client: GRPCClient;
@@ -51,6 +51,7 @@ export default class GRPCClientConfiguration implements IClientConfiguration {
       for (const [key, value] of Object.entries(metadataObj)) {
         metadata.add(key, value);
       }
+      addMetadataToMap(msg.getMetadataMap(), metadataObj);
     }
 
     const client = await this.client.getClient();
@@ -114,6 +115,7 @@ export default class GRPCClientConfiguration implements IClientConfiguration {
       for (const [key, value] of Object.entries(metadataObj)) {
         metadata.add(key, value);
       }
+      addMetadataToMap(msg.getMetadataMap(), metadataObj);
     }
 
     const client = await this.client.getClient();

diff --git a/test/e2e/grpc/client.test.ts b/test/e2e/grpc/client.test.ts
@@ -363,14 +363,11 @@ describe("grpc/client", () => {
     });
 
     it("should be able to get the configuration items with metadata", async () => {
-      await client.configuration.get("config-redis", ["myconfigkey1"], {
+      const conf = await client.configuration.get("config-redis", ["myconfigkey1"], {
         hello: "world",
       });
 
-      // Disabled for now as I am unsure if Dapr returns the metadata items
-      // Java SDK: https://github.com/dapr/java-sdk/blob/06d92dafca62a6b48e74ccf939feeac7189e360f/sdk/src/test/java/io/dapr/client/DaprPreviewClientGrpcTest.java#L119
-      // ^ shows that it is not being tested, it tries but doesn't assert
-      // expect(conf.items.filter(i => i.key == "myconfigkey1")[0].metadata).toHaveProperty("hello");
+      expect(conf.items["myconfigkey1"].metadata).toHaveProperty("hello");
     });
 
     it("should be able to subscribe to configuration item changes on all keys", async () => {