Upgrade to add JDK17 support #970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sky Ao <[email protected]>
Signed-off-by: Sky Ao <[email protected]>
|
@skyao all the tests seem to fail. Please take a look at why the install jars step fails. |
Signed-off-by: Sky Ao <[email protected]>
Signed-off-by: Sky Ao <[email protected]>
Signed-off-by: Sky Ao <[email protected]>
Signed-off-by: Sky Ao <[email protected]>
Signed-off-by: Sky Ao <[email protected]>
Signed-off-by: Sky Ao <[email protected]>
Signed-off-by: Sky Ao <[email protected]>
skyao
changed the title
Signed-off-by: Sky Ao <[email protected]>
Signed-off-by: Sky Ao <[email protected]>
…o support jdk17 Signed-off-by: Sky Ao <[email protected]>
Signed-off-by: Sky Ao <[email protected]>
Signed-off-by: Sky Ao <[email protected]>
…rectory, not test source and generated source Signed-off-by: Sky Ao <[email protected]>
|
/ok-to-test |
Signed-off-by: Sky Ao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #970 +/- ##
=========================================
Coverage 76.55% 76.55%
Complexity 1469 1469
=========================================
Files 138 138
Lines 4475 4475
Branches 527 527
=========================================
Hits 3426 3426
Misses 763 763
Partials 286 286 ☔ View full report in Codecov by Sentry. |
3 tasks
|
Close it because the content is included in PR #975 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to add JDK17 support in dapr java sdk.
For the details, please reference to the proposal: #971
Issue reference
#886
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: