Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP ISSUE-569: Allow usage of ISO 8601 interval notations #645

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TomCools
Copy link
Contributor

Description

Allow the use of ISO 8601 interval to get feature parity with: dapr/dapr#2513

Issue reference

#569

Please reference the issue this PR will close: #569

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@TomCools TomCools requested review from a team as code owners October 20, 2021 11:42
@TomCools TomCools changed the title ISSUE-569: Allow usage of ISO 8601 interval notations WIP ISSUE-569: Allow usage of ISO 8601 interval notations Oct 20, 2021
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #645 (97f6cbd) into master (91dd2fb) will decrease coverage by 0.08%.
The diff coverage is 84.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #645      +/-   ##
============================================
- Coverage     77.25%   77.17%   -0.09%     
- Complexity      946      956      +10     
============================================
  Files            88       88              
  Lines          3012     3054      +42     
  Branches        334      338       +4     
============================================
+ Hits           2327     2357      +30     
- Misses          523      532       +9     
- Partials        162      165       +3     
Impacted Files Coverage Δ
...va/io/dapr/actors/runtime/ActorReminderParams.java 89.65% <72.72%> (-10.35%) ⬇️
.../io/dapr/actors/runtime/ActorObjectSerializer.java 83.51% <83.33%> (-1.19%) ⬇️
...ain/java/io/dapr/actors/runtime/AbstractActor.java 85.52% <84.93%> (+0.19%) ⬆️
sdk/src/main/java/io/dapr/utils/DurationUtils.java 87.32% <88.57%> (-8.33%) ⬇️
...in/java/io/dapr/actors/runtime/DaprGrpcClient.java 95.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91dd2fb...97f6cbd. Read the comment docs.

@mukundansundar
Copy link
Contributor

@TomCools Can you fix conflicts in the PR? And is the PR ready for review?

@cicoyle
Copy link
Contributor

cicoyle commented Dec 21, 2023

@TomCools mind resolving the conflicts?

@cicoyle
Copy link
Contributor

cicoyle commented Feb 19, 2024

gentle ping @TomCools

1 similar comment
@cicoyle
Copy link
Contributor

cicoyle commented Jun 19, 2024

gentle ping @TomCools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ISO 8601 intervals to java sdk
4 participants