Skip to content

[1.15] Cherrypick Compensation PR + Suspend/Resume PR #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented Jun 11, 2025

cicoyle and others added 2 commits June 11, 2025 09:55
* add basic compensation example for wf

Signed-off-by: Cassandra Coyle <[email protected]>

* update commands to run + wf id

Signed-off-by: Cassandra Coyle <[email protected]>

* update readme + add mechanical markdown

Signed-off-by: Cassandra Coyle <[email protected]>

* fix import

Signed-off-by: Cassandra Coyle <[email protected]>

* fix mechanical markdown + add how to test it locally

Signed-off-by: Cassandra Coyle <[email protected]>

* move compensation example readme to workflows readme

Signed-off-by: Cassandra Coyle <[email protected]>

* Update BookCarActivity.java

Signed-off-by: artur-ciocanu <[email protected]>

* Update BookFlightActivity.java

Signed-off-by: artur-ciocanu <[email protected]>

* Update BookHotelActivity.java

Signed-off-by: artur-ciocanu <[email protected]>

* Update BookTripClient.java

Signed-off-by: artur-ciocanu <[email protected]>

* Update BookTripWorker.java

Signed-off-by: artur-ciocanu <[email protected]>

* Update BookTripWorkflow.java

Signed-off-by: artur-ciocanu <[email protected]>

* Update CancelCarActivity.java

Signed-off-by: artur-ciocanu <[email protected]>

* Update CancelFlightActivity.java

Signed-off-by: artur-ciocanu <[email protected]>

* Update CancelHotelActivity.java

Signed-off-by: artur-ciocanu <[email protected]>

* add retry IT tests and catch TaskFailedException

Signed-off-by: Cassandra Coyle <[email protected]>

* add test for no compensation if successful and assert attempts

Signed-off-by: Cassandra Coyle <[email protected]>

* update mechanical markdown

Signed-off-by: Cassandra Coyle <[email protected]>

* add back pubsub... but this should be removed long term

Signed-off-by: Cassandra Coyle <[email protected]>

* try adding waitforsidecar

Signed-off-by: Cassandra Coyle <[email protected]>

* rm tests from examples pr

Signed-off-by: Cassandra Coyle <[email protected]>

* reset unintended changes

Signed-off-by: Cassandra Coyle <[email protected]>

---------

Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: artur-ciocanu <[email protected]>
Co-authored-by: artur-ciocanu <[email protected]>
* adding IT test

Signed-off-by: salaboy <[email protected]>

* adding initial version of suspend/resume example

Signed-off-by: salaboy <[email protected]>

* updating README

Signed-off-by: salaboy <[email protected]>

* Update README.md

Signed-off-by: salaboy <[email protected]>

* following Javi's suggestion

Signed-off-by: salaboy <[email protected]>

* fixing wrong year in headers

Signed-off-by: salaboy <[email protected]>

* fixing paths in one more README.md file

Signed-off-by: salaboy <[email protected]>

* adding output validation

Signed-off-by: salaboy <[email protected]>

* adding missing port

Signed-off-by: salaboy <[email protected]>

* fixing check conditions

Signed-off-by: salaboy <[email protected]>

---------

Signed-off-by: salaboy <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
@cicoyle cicoyle requested review from a team as code owners June 11, 2025 14:59
Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Retriggered the failing PR build

@cicoyle cicoyle merged commit e297d01 into dapr:release-1.15 Jun 11, 2025
11 of 12 checks passed
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-1.15@1a69298). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.15    #1415   +/-   ##
===============================================
  Coverage                ?   77.59%           
  Complexity              ?     1779           
===============================================
  Files                   ?      205           
  Lines                   ?     5489           
  Branches                ?      600           
===============================================
  Hits                    ?     4259           
  Misses                  ?      910           
  Partials                ?      320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants