Make work queue push based #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The work item queue was pull based, meaning that if the backed had no work to do, the processor would both spin wheels doing no work as well as processing the next work item slower as there was a backoff delay to when there was no work. Updates the queue to be pull based, calling a function which hangs until there is either work to do or the context is cancelled. Signed-off-by: joshvanl <[email protected]>
famarting
approved these changes
Jan 14, 2025
yaron2
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work item queue was pull based, meaning that if the backed had no work to do, the processor would both spin wheels doing no work as well as processing the next work item slower as there was a backoff delay to when there was no work.
Updates the queue to be pull based, calling a function which hangs until there is either work to do or the context is cancelled.