Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Workflow comment for accuracy #1260

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

WhitWaldo
Copy link
Contributor

Description

Part of the XML documentation for a Workflow method is out of date following a change made in 1.13 as highlighted in issue #1251 This simply updates the XML documentation to reflect the current behavior.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1251

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly (not applicable)
  • Created/updated tests (not applicable)
  • Extended the documentation

@WhitWaldo WhitWaldo requested review from a team as code owners April 3, 2024 07:45
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (1b7c9f4) to head (f11ca4e).
Report is 2 commits behind head on master.

❗ Current head f11ca4e differs from pull request most recent head 765374b. Consider uploading reports for the commit 765374b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1260   +/-   ##
=======================================
  Coverage   67.28%   67.28%           
=======================================
  Files         174      174           
  Lines        6025     6025           
  Branches      671      671           
=======================================
  Hits         4054     4054           
  Misses       1802     1802           
  Partials      169      169           
Flag Coverage Δ
net6 67.26% <ø> (ø)
net7 67.26% <ø> (ø)
net8 67.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philliphoff philliphoff merged commit ca0bffa into dapr:master Apr 8, 2024
10 checks passed
@WhitWaldo WhitWaldo deleted the fix-workflow-docs branch April 8, 2024 23:20
@philliphoff philliphoff added this to the v1.14 milestone Jul 23, 2024
divzi-p pushed a commit to divzi-p/dotnet-sdk that referenced this pull request Dec 10, 2024
Signed-off-by: Whit Waldo <[email protected]>
Co-authored-by: Phillip Hoff <[email protected]>
Signed-off-by: Divya Perumal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded docs incorrect in 1.13
2 participants