Fix: Scheduler Actor Reminders Wording #4320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…othing to do with it really Signed-off-by: Cassandra Coyle <[email protected]>
msfussell
reviewed
Aug 15, 2024
daprdocs/content/en/operations/support/support-preview-features.md
Outdated
Show resolved
Hide resolved
…s.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Cassie Coyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to tweak the phrasing bc the
SchedulerRemindersfeature flag doesn't use the jobs api at all. It is simply storing the actor reminders in the Scheduler control plane service instead of the old actor reminder subsystem. I think it is confusing to putjob actor remindershere bc it doesn't use/touch the jobs api at all. The jobs api is user facing, this preview feature does not utilize that user facing jobs api at all it does utilize the Scheduler so there should be a distinction there and we should not overlap the concepts.