Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document "protected" pub/sub topics. #3624

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

kovalromank
Copy link
Contributor

Description

Added documentation for pub/sub protected topics. Implementation PR: dapr/dapr#6714.

Issue reference

References dapr/dapr#5843.

@kovalromank kovalromank requested review from a team as code owners July 23, 2023 20:23
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a quick review - thanks!

kovalromank and others added 2 commits July 24, 2023 16:00
…bsub/pubsub-scopes.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: kovalromank <[email protected]>
…bsub/pubsub-scopes.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: kovalromank <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Aug 2, 2023
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have raised this issue #3657 to improve the referencing to this topic.

@msfussell msfussell changed the title Document protected pub/sub topics Document "protected" pub/sub topics. Aug 2, 2023
@hhunter-ms hhunter-ms merged commit 4d444bd into dapr:v1.12 Aug 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants