Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new properties to the metadata API #3562

Merged
merged 9 commits into from
Jun 21, 2023
Merged

Add new properties to the metadata API #3562

merged 9 commits into from
Jun 21, 2023

Conversation

shubham1172
Copy link
Member

@shubham1172 shubham1172 commented Jun 17, 2023 •
edited
Loading

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This PR adds the following to metadata API options

  1. runtimeVersion
  2. appConnectionProperties
  3. subscriptions

Issue reference

This PR will close #3557

@shubham1172
Update metadata API docs
a6ffd4b 
Signed-off-by: Shubham Sharma <[email protected]>
@shubham1172 shubham1172 requested review from a team as code owners June 17, 2023 07:10
@shubham1172
Make type consistent
e20f696 
Signed-off-by: Shubham Sharma <[email protected]>
@shubham1172
Add docs for enabledFeatures
455195b 
Signed-off-by: Shubham Sharma <[email protected]>
@shubham1172 shubham1172 mentioned this pull request Jun 19, 2023
Merged
7 tasks
@shubham1172
Update docs
bf17f2d 
Signed-off-by: Shubham Sharma <[email protected]>
hhunter-ms
hhunter-ms requested changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small edits for consistency!

daprdocs/content/en/reference/api/metadata_api.md Outdated Show resolved Hide resolved
daprdocs/content/en/reference/api/metadata_api.md Outdated Show resolved Hide resolved
daprdocs/content/en/reference/api/metadata_api.md Outdated Show resolved Hide resolved
daprdocs/content/en/reference/api/metadata_api.md Outdated Show resolved Hide resolved
shubham1172 and others added 4 commits June 19, 2023 21:49
@shubham1172 @hhunter-ms
Update daprdocs/content/en/reference/api/metadata_api.md
b9e3038 
Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
@shubham1172 @hhunter-ms
Update daprdocs/content/en/reference/api/metadata_api.md
ff1281b 
Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
@shubham1172 @hhunter-ms
Update daprdocs/content/en/reference/api/metadata_api.md
a6998f2 
Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
@shubham1172 @hhunter-ms
Update daprdocs/content/en/reference/api/metadata_api.md
1923124 
Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
@shubham1172
Copy link
Member Author

@hhunter-ms thank you so much for the suggestions, merged 'em all.

@shubham1172 @msfussell
Update daprdocs/content/en/reference/api/metadata_api.md
95e976d 
Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
@msfussell
Copy link
Member

msfussell commented Jun 20, 2023 •
edited
Loading

@shubham1172 - I raised this issue #3566

@msfussell
Copy link
Member

@shubham1172 - I raised this issue dapr/dapr#6550

@shubham1172
Copy link
Member Author

shubham1172 commented Jun 20, 2023 •
edited
Loading

Thanks @msfussell, could you unassign me from #3566, probably the one who picks up the dapr runtime issue will pick the docs one.

Could you also approve/merge this PR if it looks good?

@hhunter-ms
Copy link
Collaborator

Thanks @msfussell, could you unassign me from #3566, probably the one who picks up the dapr runtime issue will pick the docs one.

just unassigned you - thanks!

@msfussell msfussell merged commit dd379f5 into dapr:v1.12 Jun 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItalyPaleAle ItalyPaleAle ItalyPaleAle left review comments

@msfussell msfussell msfussell left review comments

@hhunter-ms hhunter-ms hhunter-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shubham1172 @msfussell @hhunter-ms @ItalyPaleAle