-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs for components-path changed to resources-path #2999
Conversation
Signed-off-by: Pravin Pushkar <[email protected]>
This PR needs to be extend to cover more than just the CLI update. This is a fundamental change across many docs, since this will become the recommended way to use components. Therefore we need to update the following
I suggest that we update the Quickstarts dapr/quickstarts#769 and @hananah can maybe help here |
Signed-off-by: Pravin Pushkar <[email protected]>
Stale PR, paging all reviewers |
lets wait on this, until we decide on the PR - dapr/cli#1149. Will open it for review accordingly. |
Stale PR, paging all reviewers |
I will open it for review shortly |
Stale PR, paging all reviewers |
/keep-alive |
Stale PR, paging all reviewers |
/keep-alive - since the feature PR is still not merged |
Signed-off-by: Hannah Hunter <[email protected]>
Stale PR, paging all reviewers |
|
||
On `dapr init`, the CLI also creates a default components folder that contains several YAML files with definitions for a state store, Pub/sub, and Zipkin. The Dapr sidecar will read these components and use: | ||
On `dapr init`, the CLI also creates a default resources folder that contains several YAML files with definitions for a state store, Pub/sub, and Zipkin. The Dapr sidecar will read these resources and use: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On `dapr init`, the CLI also creates a default resources folder that contains several YAML files with definitions for a state store, Pub/sub, and Zipkin. The Dapr sidecar will read these resources and use: | |
On `dapr init`, the CLI also creates a default resources folder that contains several YAML component files with specifications for a state store, pub/sub, and Zipkin. The Dapr sidecar loads these component resources and uses: |
|
||
On `dapr init`, the CLI also creates a default components folder that contains several YAML files with definitions for a state store, Pub/sub, and Zipkin. The Dapr sidecar will read these components and use: | ||
On `dapr init`, the CLI also creates a default resources folder that contains several YAML files with definitions for a state store, Pub/sub, and Zipkin. The Dapr sidecar will read these resources and use: | ||
|
||
- The Redis container for state management and messaging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The Redis container for state management and messaging. | |
- The Redis container for both state management and pub/sub messaging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pravinpushkar - Looks like you added this file daprdocs/package-lock.json
by accident.
Stale PR, paging all reviewers |
Don't we need this ? Normally, we do checkin the lock file for node project AFAIK ? |
Aborting this PR as feature PR is not merged for this release - dapr/cli#1149. and doc changes for resources-path has already been covered via a different PR - #3016 |
Signed-off-by: Pravin Pushkar [email protected]
Thank you for helping make the Dapr documentation better!
Issue reference
1st PR (--components-path changed to resources-path)- dapr/cli#1012
2nd PR( components directory changed to resources direcotory)- dapr/cli#1149