Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs for components-path changed to resources-path #2999

Closed
wants to merge 3 commits into from

Conversation

pravinpushkar
Copy link
Contributor

@pravinpushkar pravinpushkar commented Dec 8, 2022

Signed-off-by: Pravin Pushkar [email protected]

Thank you for helping make the Dapr documentation better!

Issue reference

1st PR (--components-path changed to resources-path)- dapr/cli#1012
2nd PR( components directory changed to resources direcotory)- dapr/cli#1149

@msfussell
Copy link
Member

This PR needs to be extend to cover more than just the CLI update. This is a fundamental change across many docs, since this will become the recommended way to use components. Therefore we need to update the following

I suggest that we update the Quickstarts dapr/quickstarts#769 and @hananah can maybe help here

@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 20, 2022
@pravinpushkar
Copy link
Contributor Author

lets wait on this, until we decide on the PR - dapr/cli#1149. Will open it for review accordingly.

@github-actions github-actions bot removed the stale label Dec 21, 2022
@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 26, 2022
@pravinpushkar
Copy link
Contributor Author

I will open it for review shortly

@github-actions github-actions bot removed the stale label Dec 27, 2022
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 1, 2023
@pravinpushkar
Copy link
Contributor Author

/keep-alive

@github-actions github-actions bot removed the stale label Jan 3, 2023
@github-actions
Copy link

github-actions bot commented Jan 8, 2023

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 8, 2023
@pravinpushkar
Copy link
Contributor Author

/keep-alive - since the feature PR is still not merged

@github-actions github-actions bot removed the stale label Jan 13, 2023
@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 24, 2023
@msfussell msfussell removed the stale label Jan 24, 2023

On `dapr init`, the CLI also creates a default components folder that contains several YAML files with definitions for a state store, Pub/sub, and Zipkin. The Dapr sidecar will read these components and use:
On `dapr init`, the CLI also creates a default resources folder that contains several YAML files with definitions for a state store, Pub/sub, and Zipkin. The Dapr sidecar will read these resources and use:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
On `dapr init`, the CLI also creates a default resources folder that contains several YAML files with definitions for a state store, Pub/sub, and Zipkin. The Dapr sidecar will read these resources and use:
On `dapr init`, the CLI also creates a default resources folder that contains several YAML component files with specifications for a state store, pub/sub, and Zipkin. The Dapr sidecar loads these component resources and uses:


On `dapr init`, the CLI also creates a default components folder that contains several YAML files with definitions for a state store, Pub/sub, and Zipkin. The Dapr sidecar will read these components and use:
On `dapr init`, the CLI also creates a default resources folder that contains several YAML files with definitions for a state store, Pub/sub, and Zipkin. The Dapr sidecar will read these resources and use:

- The Redis container for state management and messaging.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The Redis container for state management and messaging.
- The Redis container for both state management and pub/sub messaging.

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pravinpushkar - Looks like you added this file daprdocs/package-lock.json by accident.

@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 30, 2023
@pravinpushkar
Copy link
Contributor Author

@pravinpushkar - Looks like you added this file daprdocs/package-lock.json by accident.

Don't we need this ? Normally, we do checkin the lock file for node project AFAIK ?

@hhunter-ms hhunter-ms removed the stale label Jan 30, 2023
@pravinpushkar
Copy link
Contributor Author

Aborting this PR as feature PR is not merged for this release - dapr/cli#1149.
I will open a fresh PR once that gets merged.

and doc changes for resources-path has already been covered via a different PR - #3016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants