Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to go 1.21 and bump deps #273

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

toneill818
Copy link
Contributor

Upgrade to go 1.21 and bump dependencies

@yaron2 yaron2 closed this Feb 16, 2024
@yaron2 yaron2 reopened this Feb 16, 2024
@yaron2
Copy link
Member

yaron2 commented Feb 16, 2024

@toneill818 can you please check why the build is failing?

@yaron2
Copy link
Member

yaron2 commented Feb 29, 2024

Ping @toneill818

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.56%. Comparing base (298a16a) to head (16f305d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   27.56%   27.56%           
=======================================
  Files           7        7           
  Lines         798      798           
=======================================
  Hits          220      220           
  Misses        554      554           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@toneill818
Copy link
Contributor Author

@yaron2 Builds seem to be failing due to an old node version. Is it okay if I modify the node version for the runners in this PR?

The Angular CLI requires a minimum Node.js version of v18.13.

@yaron2
Copy link
Member

yaron2 commented Feb 29, 2024

@yaron2 Builds seem to be failing due to an old node version. Is it okay if I modify the node version for the runners in this PR?

The Angular CLI requires a minimum Node.js version of v18.13.

Sure

@toneill818
Copy link
Contributor Author

@yaron2 Builds seem to be failing due to an old node version. Is it okay if I modify the node version for the runners in this PR?

The Angular CLI requires a minimum Node.js version of v18.13.

Sure

Should be fixed

@yaron2 yaron2 merged commit 6d4c52a into dapr:master Feb 29, 2024
12 of 13 checks passed
@yaron2
Copy link
Member

yaron2 commented Feb 29, 2024

@yaron2 Builds seem to be failing due to an old node version. Is it okay if I modify the node version for the runners in this PR?

The Angular CLI requires a minimum Node.js version of v18.13.

Sure

Should be fixed

Thanks!

@yaron2 yaron2 added this to the 0.15.0 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants