Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow .yml files as components #270

Merged
merged 2 commits into from
Feb 29, 2024
Merged

allow .yml files as components #270

merged 2 commits into from
Feb 29, 2024

Conversation

andrew-hillier
Copy link
Contributor

@andrew-hillier andrew-hillier commented Dec 7, 2023

I suspect that this will resolve #195

@yaron2
Copy link
Member

yaron2 commented Dec 15, 2023

Thanks for this contribution!

@yaron2
Copy link
Member

yaron2 commented Feb 29, 2024

@andrew-hillier please check why build tests are failing

@andrew-hillier
Copy link
Contributor Author

@andrew-hillier please check why build tests are failing

Hey! It's due to slices only being available from go 1.21, so have updated to use this one instead, that was available for 1.19:
https://pkg.go.dev/golang.org/x/exp/slices

Once the project is updated to 1.21+, then this can be updated to use the slices standard library package once more.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 27.84%. Comparing base (6d4c52a) to head (34f846e).

Files Patch % Lines
pkg/components/components.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   27.56%   27.84%   +0.27%     
==========================================
  Files           7        7              
  Lines         798      801       +3     
==========================================
+ Hits          220      223       +3     
  Misses        554      554              
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaron2
Copy link
Member

yaron2 commented Feb 29, 2024

@andrew-hillier thanks, we've now upgraded to Go 1.21. if you can resolve the conflicts that'd be great, and we can then merge

@andrew-hillier
Copy link
Contributor Author

I'll revert the latest commit, as we can use slices from the standard lib too

@andrew-hillier
Copy link
Contributor Author

@yaron2, had a little trouble with the DCO, but that should be ready to build now.

@yaron2 yaron2 merged commit a92b8cd into dapr:master Feb 29, 2024
12 of 13 checks passed
@andrew-hillier andrew-hillier deleted the add-support-for-yml-files branch February 29, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dapr dashboard doesn't show local app-only components
3 participants