Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12] Delete injector mutating webhook on downgrade from 1.12 to 1.11 #1359

Open
wants to merge 10 commits into
base: release-1.12
Choose a base branch
from

Conversation

JoshVanL
Copy link
Contributor

If a downgrade is occurring for 1.12 to 1.11, delete the injector mutating webhook so that 1.11 helm chart installs correct CA bundle. Re-create webhook in the event of upgrade failing.

See: dapr/dapr#7055 (comment)

@JoshVanL JoshVanL requested review from a team as code owners October 18, 2023 20:22
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (1d60280) 22.76% compared to head (b5d5fc7) 22.59%.

Files Patch % Lines
pkg/kubernetes/upgrade.go 0.00% 37 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #1359      +/-   ##
================================================
- Coverage         22.76%   22.59%   -0.18%     
================================================
  Files                40       40              
  Lines              4713     4749      +36     
================================================
  Hits               1073     1073              
- Misses             3562     3598      +36     
  Partials             78       78              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: joshvanl <[email protected]>
@JoshVanL JoshVanL closed this Oct 23, 2023
@JoshVanL JoshVanL reopened this Oct 23, 2023
@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@mukundansundar
Copy link
Collaborator

@JoshVanL is this PR still relevant based on the conversation in issue dapr/dapr#7055 (comment)

cc @yaron2

@JoshVanL
Copy link
Contributor Author

@JoshVanL is this PR still relevant based on the conversation in issue dapr/dapr#7055 (comment)

cc @yaron2

@mukundansundar yes, this PR was intended to improve downgrade support by covering all 1.11 releases, not only those with the helm chart fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants