-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed #11 - Uncaught (in promise) ReferenceError: Web3 is not defined #12
Open
jdohm
wants to merge
2
commits into
dappuniversity:master
Choose a base branch
from
jdohm:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is not defined This issue is due to the fact that metamask no longer injects web3 by default package.json - added web3 dependency src/index.html - added web3 dependency
this resolves the following issue: Uncaught (in promise) Error: invalid address at inputAddressFormatter (formatters.js:274)
Thanks for initiating this PR! Saved a lot of time for me :) Your change works! |
Thank You!!! |
Thank you!! |
Thanks! Works! |
it helps a lot, thanks |
anilnabin25
approved these changes
Aug 31, 2021
Thanks @jdohm! Worked like a charm |
Great fix - thanks for this |
ByWaleed
approved these changes
Dec 12, 2021
Thank you! |
Good job. It's killed me |
Thanks! I vote this gets merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is due to the fact that metamask no longer injects web3 by default
set default account to use on web3
this resolves the following issue:
Uncaught (in promise) Error: invalid address
at inputAddressFormatter (formatters.js:274)
package.json
src/app.js
src/index.html