Add flag and task to sign release #461
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 23bbb0d This is a development version and should only be installed for testing purposes.
Hash: (by dappnodebot/build-action) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag
--sign-releasewhich signs the release with a private key provided via ENVSIGNING_KEY.Basically does the step of https://github.com/dappnode/sdk-publish but in the DAppNode SDK. Ideally you should delete the code from the sdk-publish repo and make the sdk-publish import from the DAppNode SDK.
The end goal is to automatically sign and publish packages from CI without the manual interaction of mantainers
I had to bump a bump of dependencies to get tests working locally