-
Notifications
You must be signed in to change notification settings - Fork 28
[BREAKING] Change publish cmd to not mutate version #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dapplion
wants to merge
1
commit into
master
Choose a base branch
from
dapplion/publish-no-version-mutate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import { CommandModule } from "yargs"; | ||
| import { CliGlobalOptions } from "../types"; | ||
| import { defaultDir } from "../params"; | ||
| import { readManifest } from "../utils/manifest"; | ||
| import { Apm } from "../utils/Apm"; | ||
|
|
||
| interface CliCommandOptions extends CliGlobalOptions { | ||
| provider: string; | ||
| tag?: string; | ||
| } | ||
|
|
||
| export const list: CommandModule<CliGlobalOptions, CliCommandOptions> = { | ||
| command: "list [tag]", | ||
| describe: "List package version tags", | ||
|
|
||
| builder: yargs => | ||
| yargs | ||
| .positional("tag", { | ||
| description: "tag to print version of", | ||
| type: "string" | ||
| }) | ||
| .option("provider", { | ||
| description: `Specify an eth provider: "dappnode" (default), "infura", "localhost:8545"`, | ||
| default: "dappnode", | ||
| type: "string" | ||
| }), | ||
|
|
||
| handler: async (args): Promise<void> => { | ||
| const tagsWithVersions = await listHandler(args); | ||
|
|
||
| if (args.tag) { | ||
| // Output result: "0.1.8" | ||
| const version = tagsWithVersions[args.tag]; | ||
| if (!version) { | ||
| throw Error(`Tag ${args.tag} not found`); | ||
| } else { | ||
| console.log(version); | ||
| } | ||
| } else { | ||
| for (const [tag, version] of Object.entries(tagsWithVersions)) { | ||
| // Output result: "latest: 0.1.8" | ||
| console.log(`${tag}: ${version}`); | ||
| } | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| /** | ||
| * Common handler for CLI and programatic usage | ||
| */ | ||
| export async function listHandler({ | ||
| provider, | ||
| dir = defaultDir | ||
| }: CliCommandOptions): Promise<Record<string, string>> { | ||
| const { manifest } = readManifest({ dir }); | ||
|
|
||
| return { | ||
| latest: await new Apm(provider).getLatestVersion(manifest.name) | ||
| }; | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| import { CommandModule } from "yargs"; | ||
| import semver from "semver"; | ||
| import { CliGlobalOptions } from "../types"; | ||
| import { defaultComposeFileName, defaultDir } from "../params"; | ||
| import { readManifest, writeManifest } from "../utils/manifest"; | ||
| import { | ||
| readCompose, | ||
| updateComposeImageTags, | ||
| writeCompose | ||
| } from "../utils/compose"; | ||
|
|
||
| interface CliCommandOptions extends CliGlobalOptions { | ||
| type: string; | ||
| } | ||
|
|
||
| export const version: CommandModule<CliGlobalOptions, CliCommandOptions> = { | ||
| command: "version [type]", | ||
| describe: "Bump a package version", | ||
|
|
||
| builder: yargs => | ||
| yargs.positional("type", { | ||
| description: "Semver update type: [ major | minor | patch ]", | ||
| choices: ["major", "minor", "patch"], | ||
| type: "string", | ||
| demandOption: true | ||
| }), | ||
|
|
||
| handler: async (args): Promise<void> => { | ||
| const nextVersion = await versionHandler(args); | ||
| // Output result: "0.1.8" | ||
| console.log(nextVersion); | ||
| } | ||
| }; | ||
|
|
||
| /** | ||
| * Common handler for CLI and programatic usage | ||
| */ | ||
| export async function versionHandler({ | ||
| type, | ||
| dir = defaultDir, | ||
| compose_file_name: composeFileName = defaultComposeFileName | ||
| }: CliCommandOptions): Promise<string> { | ||
| // Load manifest | ||
| const { manifest, format } = readManifest({ dir }); | ||
|
|
||
| // If `type` is a valid `semver.ReleaseType` the version will be bumped, else return null | ||
| const nextVersion = | ||
| semver.inc(manifest.version, type as semver.ReleaseType) || type; | ||
| if (!semver.valid(nextVersion)) { | ||
| throw Error(`Invalid semver bump or version: ${type}`); | ||
| } | ||
|
|
||
| // Mofidy and write the manifest and docker-compose | ||
| manifest.version = nextVersion; | ||
| writeManifest(manifest, format, { dir }); | ||
|
|
||
| const { name, version } = manifest; | ||
| const compose = readCompose({ dir, composeFileName }); | ||
| const newCompose = updateComposeImageTags(compose, { name, version }); | ||
| writeCompose(newCompose, { dir, composeFileName }); | ||
|
|
||
| return nextVersion; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
versionis a name that says nothing, what aboutbumpVersion?