Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed media type for square image #269

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

judezhu
Copy link
Contributor

@judezhu judezhu commented Sep 20, 2024

No description provided.

@judezhu judezhu requested a review from a team as a code owner September 20, 2024 23:31
@@ -1691,7 +1691,7 @@ access(all) contract TopShot: NonFungibleToken {
file: MetadataViews.HTTPFile(
url: "https://nbatopshot.com/static/favicon/favicon.svg"
),
mediaType: "image/png"
mediaType: "image/svg+xml"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annatangzhao made a change in the media type.

Copy link
Contributor

@annatangzhao annatangzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants