Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-17133 ci: Add to codespell skip list #15932

Merged
merged 2 commits into from
Feb 18, 2025
Merged

DAOS-17133 ci: Add to codespell skip list #15932

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f68036f
DAOS-17133 ci: Add to codespell skip list
jolivier23 Feb 18, 2025
1f5b0b2
Address review comment
jolivier23 Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/linting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ jobs:
- name: Run check
uses: codespell-project/actions-codespell@406322ec52dd7b488e48c1c4b82e2a8b3a1bf630 # master
with:
skip: ./src/control/vendor,./src/control/go.sum,./.git
skip: ./src/control/vendor,./src/control/go.sum,./.git,./utils/*.patch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add these here to reduce potential conflicts between google/2.6 and master branch

ignore_words_file: ci/codespell.ignores
builtin: clear,rare,informal,names,en-GB_to_en-US

Expand Down
3 changes: 2 additions & 1 deletion utils/githooks/pre-commit.d/20-codespell.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/usr/bin/env bash
#
# Copyright 2024 Intel Corporation.
# Copyright 2025 Google LLC
# Copyright 2025 Hewlett Packard Enterprise Development LP
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
Expand All @@ -22,4 +23,4 @@ fi

echo "Checking for spelling mistakes"
# Convert file names to relative path format that codespell expects. I.e. "./path"
_git_diff_cached_files | xargs -r -n 1 -I% echo "./%" | xargs -r codespell
_git_diff_cached_files | xargs -r -n 1 -I% echo "./%" | xargs -r codespell --skip ./src/control/vendor,./src/control/go.sum,./utils/*.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are actually specified here:

daos/pyproject.toml

Lines 7 to 11 in ae9f129

[tool.codespell]
skip = './src/control/vendor/*,./src/control/go.sum,./.git/*,./src/rdb/raft/*,./build/*,./install/*,./venv/*,./src/control/security/testdata/certs/source.txt'
quiet-level = 3
ignore-words = 'ci/codespell.ignores'
builtin = 'clear,rare,informal,names,en-GB_to_en-US'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will change it

Loading