Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16927 include: Trigger testing #15916

Closed
wants to merge 1 commit into from
Closed

DAOS-16927 include: Trigger testing #15916

wants to merge 1 commit into from

Conversation

liw
Copy link
Contributor

@liw liw commented Feb 17, 2025

Just to trigger testing; not for landing.

Test-tag: metadata
Test-repeat: 3

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@liw
DAOS-16927 include: Trigger testing
6697a8f 
Just to trigger testing; not for landing.

Test-tag: metadata
Test-repeat: 3
Signed-off-by: Li Wei <[email protected]>
@github-actions GitHub Actions
Copy link

Ticket title is 'Special pool and container handles should be stored persistently in RDBs'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16927

@liw liw mentioned this pull request Feb 17, 2025
Open
18 tasks
@kccain
Copy link
Contributor

kccain commented Feb 18, 2025

I accidentally approved this debug PR when I intended to do that on the main code change PR.

@liw
Copy link
Contributor Author

liw commented Feb 19, 2025

I accidentally approved this debug PR when I intended to do that on the main code change PR.

Seems the test is stable (the successful run has test-repeat: 3).

@liw liw closed this Feb 19, 2025
@liw liw deleted the liw/special-hdls-test branch February 19, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kccain kccain kccain approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liw @kccain