Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-17117 build: build dependencies as git submodules #15909

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DAOS-17117 build: build dependencies as git submodules #15909

wants to merge 1 commit into from
+51 −5

Conversation

techbasset
Copy link
Contributor

  • add --deps-as-gitmodules-subdir flag that ignores branch, tag, and commit information for dependencies in build.config and expects such dependencies to exist as submodules in the supplied sub-directory (relative to base of repo)
  • build such dependencies in place by inserting relative symlinks into the build directory

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@techbasset techbasset requested review from a team as code owners February 14, 2025 03:57
@github-actions GitHub Actions
Copy link

Ticket title is 'Support building dependencies as git submodules'
Status is 'Open'
Labels: 'google-cloud-daos'
https://daosio.atlassian.net/browse/DAOS-17117

@techbasset techbasset force-pushed the ncmurphy/master-DAOS-17117 branch 2 times, most recently from e515456 to b8dd79a Compare February 14, 2025 04:32
@techbasset
DAOS-17117 build: build dependencies as git submodules
2cbfdad 
* add --deps-as-gitmodules-subdir flag that ignores branch, tag, and
  commit information for dependencies in build.config and expects
  such dependencies to exist as submodules in the supplied
  sub-directory (relative to base of repo)
* build such dependencies in place by inserting relative
  symlinks into the build directory

Signed-off-by: Nicholas Murphy <[email protected]>
@techbasset techbasset force-pushed the ncmurphy/master-DAOS-17117 branch from b8dd79a to 2cbfdad Compare February 14, 2025 04:38
daltonbohning
daltonbohning reviewed Feb 14, 2025
View reviewed changes
site_scons/prereq_tools/base.py
@@ -715,15 +717,15 @@ def __parse_build_deps(self):
if not skip_download:
self.download_deps = True

def _sub_path(self, path):
def sub_path(self, path):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this? If it's only used internally it's better to start with _ for convention

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's internal to PreReqComponent and I wanted to use it in _Component. It didn't seem to work unless I removed the underscore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolivier23 jolivier23 jolivier23 approved these changes

@daltonbohning daltonbohning Awaiting requested review from daltonbohning

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@techbasset @jolivier23 @daltonbohning