Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-17094 container: increase stack size of cont_refresh_track_eph_one ULT #15886

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kccain
Copy link
Contributor

@kccain kccain commented Feb 11, 2025

With this change, the cont_refresh_track_eph_one ULT that itself is
created within iv_op_ult() and ds_cont_tgt_refresh_track_eph()
is configured to use a deep stack size (64KiB) rather than 16KiB.

This change is made because intermittent engine segmentation faults
were observed in ABTI_mem_pool_alloc() during CI testing.
This is a similar "solution" to the same segmentation fault that
was observed in other code paths, and fixed in PR 15822.

Features: container test_engine_restart

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium-ucx-provider: false
Test-tag: test_engine_restart

Test-repeat: 10

Signed-off-by: Kenneth Cain <[email protected]>
Copy link

github-actions bot commented Feb 11, 2025

Ticket title is 'server/daos_server_restart.py:DaosServerTest.test_engine_restart - segmentation fault in ABTI_mem_pool_alloc'
Status is 'In Progress'
Labels: 'ci_master_daily,daily_test,scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-17094

Signed-off-by: Kenneth Cain <[email protected]>
Features: container test_engine_restart
@kccain kccain changed the title Skip-unit-tests: true DAOS-17094 container: increase stack size of cont_refresh_track_eph_one ULT Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant