Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16940 common: Update pool map levels #15871

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kjacque
Copy link
Contributor

@kjacque kjacque commented Feb 8, 2025

  • Rename pool map levels to allow for optional fault domain level above
    node.
  • Rename any performance domain "group" terminology.
  • Update compressed fault domain tree parsing to include metadata about
    whether to include optional fault or performance domains.
  • Update compressed domain tree format in control plane.

Signed-off-by: Kris Jacque [email protected]

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

- Rename pool map levels to allow for optional fault domain level above
  node.
- Rename any performance domain "group" terminology.
- Update compressed fault domain tree parsing to include metadata about
  whether to include optional fault or performance domains.

Signed-off-by: Kris Jacque <[email protected]>
@kjacque kjacque self-assigned this Feb 8, 2025
Copy link

github-actions bot commented Feb 8, 2025

Ticket title is 'Update internal pool map levels '
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16940

Features: control pool

Signed-off-by: Kris Jacque <[email protected]>
@kjacque kjacque force-pushed the kjacque/pool-map-layer-rename branch from 99fb369 to 2ec7b9b Compare February 8, 2025 01:08
@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15871/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15871/2/testReport/

Features: control pool

Signed-off-by: Kris Jacque <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15871/3/execution/node/1421/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants