Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-17052 test: update expected msg for critical_integration #15855

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

daltonbohning
Copy link
Contributor

Updated the expected journalctl message from "exited with 0" to "killed", since #15811 changed the default dmg system stop to use --force.

Skip-unit-tests: true
Skip-fault-injection-test: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Updated the expected journalctl message from "exited with 0" to "killed",
since #15811 changed the default dmg system stop to use --force.

Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning self-assigned this Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Ticket title is 'deployment/critical_integration.py:CriticalIntegrationWithServers.test_ras - Rank shut down message not found in journalctl'
Status is 'In Progress'
Labels: '2.6.3rc2,triaged,weekly_test'
https://daosio.atlassian.net/browse/DAOS-17052

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15855/1/testReport/

Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning
Copy link
Contributor Author

@daltonbohning daltonbohning marked this pull request as ready for review February 13, 2025 18:36
@daltonbohning daltonbohning requested review from a team as code owners February 13, 2025 18:36
@daltonbohning daltonbohning requested a review from a team February 13, 2025 20:27
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Feb 13, 2025
@daltonbohning daltonbohning removed the request for review from a team February 13, 2025 20:27
@phender phender requested a review from a team February 13, 2025 22:10
@phender phender merged commit 5829a04 into release/2.6 Feb 13, 2025
48 checks passed
@phender phender deleted the dbohning/daos-17052 branch February 13, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

5 participants