-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSH Tunnel support #246
Open
danvergara
wants to merge
10
commits into
main
Choose a base branch
from
add-ssh-tunnel-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SSH Tunnel support #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvironment to play with
…tunnel connection
danvergara
added
kind/enhancement
New feature or request
expert
Good for advanced developers
and removed
expert
Good for advanced developers
labels
Jan 2, 2025
ThiagoMowszet
approved these changes
Jan 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow!
rkgarcia
approved these changes
Jan 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an excellent feature!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSH tunnel support
Description
This PR adds support for SSH Tunnel as requested many times in #205. It adds 6 new flags to the cli tool to perform the connection.
e.g.
This change only adds support for
MySQL
andPostgres
, more to come later.Fixes #205
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
A new docker compose file has been added to the development environment, adding a service called
ssh
, withubuntu-sshd
being its underlying base image to act as the ssh server to test the connection against.Also, a mock ssh server has been added to the test suite, to validate the use of the private key file as authentication method.
Checklist: