-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coinbase rate limits impact calls for arbitrarily large number of pages #389
Open
angelaponte
wants to merge
31
commits into
danpaquin:master
Choose a base branch
from
angelaponte:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
458bce5
Request limit in paginated message
angelaponte 11930c4
sleep_interval added to paginated calls
angelaponte 1e463a5
Decreased performance penalty
angelaponte 9e6c291
Added get_profile and get_profiles calls
angelaponte 069cc43
Made sleep_interval a keyword argument
angelaponte 55b48b2
Removed sleep_interval keyword parameters
angelaponte e697d11
Trying to handle exception in paginated generator
angelaponte 1b40752
More pagination exceptions in generator
angelaponte 6256edf
Sending troubleshooting output
angelaponte b07dfec
Fixed indentation issue in _send_paginated_message
angelaponte 8f9e43a
Added more output to the exception
angelaponte a9827a2
Added check for empty result
angelaponte d270a98
Trying to remove empty results
angelaponte d8f9833
Added output every time I sleep
angelaponte b51ba2a
Flushed the print statements
angelaponte cb5fd1e
Added sleep higher up
angelaponte af70242
Is sleep_interval being passed?
angelaponte e7c0ace
Fixed the sleep code . . .
angelaponte a36c72a
Reinserted exception code
angelaponte f6a2162
Converted the generated result to a string
angelaponte ac09443
Removed exception and extra sleep calls
angelaponte 97f53e4
How long do I sleep?
angelaponte 5635e4c
Code cleanup for many pages of results
angelaponte ebb9ff3
Maybe the sleep works correctly now.
angelaponte de098e0
Moved the cast to a string to the results line
angelaponte 216e221
Moved the cast to a string again
angelaponte eaa8429
Removed the string cast and added an empty yield
angelaponte bdc1067
Ugh!
angelaponte 9925599
Back to casting the result to a string
angelaponte fdc3e68
Fixing cast to string
angelaponte 7238b00
Removed the cast to a string
angelaponte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GET /profile
has a parameteractive
so we should add some logic in case this parameter is provided (pass as keyword argumentdata
to_send_message()