Fixed issue with message -> code. added rate limit exception and tset

danpaquin · Mar 26, 2018 · e0d5f18 · e0d5f18
1 parent 85e93c0
commit e0d5f18
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/gdax/exceptions.py b/gdax/exceptions.py
@@ -28,7 +28,7 @@ def code(self):
         return self._code
 
     @message.setter
-    def message(self, code):
+    def code(self, code):
         self._code = code
 
 
@@ -60,6 +60,13 @@ class NotFoundGdaxRequest(GdaxException):
     pass
 
 
+class GdaxRateLimitRequest(GdaxException):
+    """
+    Raised on 429 response from GDAX
+    """
+    pass
+
+
 class UnknownGdaxClientRequest(GdaxException):
     """
     Raised on 4XX responses not tracked

diff --git a/gdax/public_client.py b/gdax/public_client.py
@@ -66,6 +66,9 @@ def _determine_response(self, response):
             elif response.status_code == HTTPStatus.NOT_FOUND:
                 raise exceptions.NotFoundGdaxRequest(message,
                                                      HTTPStatus.NOT_FOUND)
+            elif response.status_code == HTTPStatus.TOO_MANY_REQUESTS:
+                raise exceptions.GdaxRateLimitRequest(message,
+                                                      HTTPStatus.TOO_MANY_REQUESTS)
             else:  # Other 4XX response not yet mapped
                 raise exceptions.UnknownGdaxClientRequest(message,
                                                           response.status_code)

diff --git a/tests/test_error_handling.py b/tests/test_error_handling.py
@@ -14,6 +14,7 @@ def client():
                          (403, gdax.exceptions.ForbiddenGdaxRequest),
                          (404, gdax.exceptions.NotFoundGdaxRequest),
                          (422, gdax.exceptions.UnknownGdaxClientRequest),
+                         (429, gdax.exceptions.GdaxRateLimitRequest),
                          (500, gdax.exceptions.InternalErrorGdaxRequest)])
 @patch('requests.get')
 def test_gdax_exceptions(mock_request, client, code, exception):