Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 feat: enhance UI & accessibility in file handling components #5086

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

berry-13
Copy link
Collaborator

@berry-13 berry-13 commented Dec 23, 2024

Summary

  • 🌟 UI Enhancements & Accessibility Improvements

    • ImagePreview Component:

      • 🖼️ Added modal functionality for viewing images in full size
      • ⌨️ Improved keyboard accessibility and focus management [1] [2]
    • FileRow and RemoveFile Components:

      • 📏 Updated inline style to include a gap for improved layout
      • 🎨 Refined button styles for consistent user experience
  • 🌍 Localization Enhancements

    • Replaced hardcoded text with localized strings across ArchivedChatsTable and BookmarkTable [1] [2] [3] [4]
  • 🚀 Additional Improvements

    • 🎨 Enhanced button hover styles in PanelColumns [1] [2]
    • 🧹 Simplified PanelFileCell by removing unnecessary logic
    • 🛠️ Refactored PanelTable to utilize memoized pagination and added missing imports [1] [2] [3] [4]

Closes #4131

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • a11y

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@danny-avila danny-avila merged commit dfe5498 into main Dec 23, 2024
2 checks passed
@danny-avila danny-avila deleted the style/file branch December 23, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Focus Visible on File Buttons
2 participants