Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Collaborative Agents are only editable by ADMIN #4659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leon-juenemann
Copy link

Summary

I expect users to be able to edit Agents, that are set to "Allow other users to edit your agent" (collaborative). Currently only the ADMIN can do this.
I know Agents are still in development. Hopefully contributions are still possible. Sharing/Editing Agents is very useful to me.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

  1. Create an Agent.
  2. Set the "Share to all users" and "Allow other users to edit your agent" option
  3. Try to edit the Agent on an account that is not ADMIN
  4. You get an error.

Test Configuration:

You need to configure Librechat to use the new Agents! See: #3607

Add to .env:
ENDPOINTS=agents
EXPERIMENTAL_AGENTS=true

Checklist

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code

@rio100
Copy link

rio100 commented Nov 9, 2024

Thinking out loud here:

On #2, if all have access to edit an agent made public, I find it would be difficult to control what the agent will do for all. I suggest an offer to copy/clone the agent for each user's profile. This way they can just have the snapshot and then if it gets updated by the author, they get a new offer and decide to copy/clone and/or reshare as their own to offer.

@leon-juenemann
Copy link
Author

Thinking out loud here:

On #2, if all have access to edit an agent made public, I find it would be difficult to control what the agent will do for all. I suggest an offer to copy/clone the agent for each user's profile. This way they can just have the snapshot and then if it gets updated by the author, they get a new offer and decide to copy/clone and/or reshare as their own to offer.

Makes sense. We could change the "Save" button to "Create Copy" for collaborative agents and change the toggle to "Allow other users to copy your agent".

Although the feature still does not feel very useful to me. I feel like the import part is that the user can see the "implementation" of the public agent. Then he can chose to create his own copy of the agent by simply copying the prompt, actions, etc.

Can @danny-avila comment on what you had in mind for this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants