Library: removed "one path down" from library lookup #6549
Conversation
|
I first assumed this is some ancient workaround for cases where we did not copy all the configuration files but this is not the case. This was added in #5082 and looks quite suspect. Looking at how many commits where done it is possible this is just some leftover. Also this is not a valid location for the files to exist in and if it were this would need to be applied to all paths and files we load but it is not. As it was only introduced recently (exactly 13 months ago) and was applied inconsistently I do not think we need to do an intermediate deprecation or error step and can simply remove it. I still would like to get the Python tests into the Cygwin and MinGW steps to make sure this actually works (testing it locally is next to impossible because of the abysmal linking times which are somehow a multiple of the ones seen in the CI). |
|
I have no idea why I added that anymore, presumably to fix a test. I'm fine with removing it. |
firewave
force-pushed
the
lib-rel
branch
3 times, most recently
from
f78372a to
f166cd1
Compare
firewave
force-pushed
the
lib-rel
branch
2 times, most recently
from
01eeb3c to
800eb9e
Compare
|
Adding the tests highlights that we cannot hard-code the path separator in Windows binaries as it depends on the underlying command-line interface. I made some changes in the past which normalized all internal paths into a front-slash but those were reverted shortly after. So adding the tests needs to be be done separately and the actual change need to be applied without any tests for now. |
No description provided.