WIP: Adding network CRUD support #24
Conversation
|
I'm fairly new to go so if anybody see something wrong, please comment :D |
|
Hi @AliceIW It's always great to see more contributions :) I'll take a look at it this weekend and provide some feedback. PS: Sorry for the late reply. |
There was a problem hiding this comment.
@AliceIW Great work. I have provided a few suggestions regarding function scoping.
To be able to merge this, would you be able to also do the documentation? Simply add the data source and resource documentation in the proper docs subfolder, and provide information about supported arguments and attributes. You can see the documentation here:
http://danitso.com/terraform-provider-proxmox/
You are also welcome to add these changes to CHANGELOG.md to avoid having to do it before the next release.
| return nil | ||
| } | ||
|
|
||
| func getBody(d *schema.ResourceData, isUpdate bool) *proxmox.VirtualEnvironmentNetworkInterfaceCreateRequestBody { |
There was a problem hiding this comment.
Consider renaming to resourceVirtualEnvironmentNetworkGetBody to prevent name collision across resources.
| return body | ||
| } | ||
|
|
||
| func assignIfStringExists(d *schema.ResourceData, p **string, key string) { |
There was a problem hiding this comment.
Consider renaming to resourceVirtualEnvironmentNetworkAssignIfStringExists or move it to utils.go.
| *p = &stringVal | ||
| } | ||
|
|
||
| func assignIfBoolExists(d *schema.ResourceData, p **bool, key string) { |
There was a problem hiding this comment.
Consider renaming to resourceVirtualEnvironmentNetworkAssignIfBoolExists or move it to utils.go.
| *p = &stringVal | ||
| } | ||
|
|
||
| func assignIfIntExists(d *schema.ResourceData, p **int, key string) { |
There was a problem hiding this comment.
Consider renaming to resourceVirtualEnvironmentNetworkAssignIfIntExists or move it to utils.go.
Community Note
Release note for CHANGELOG:
I opened the PR simply to inform other maintainer about the feature I'm currently adding to avoid duplicate work.