Feature/apply pretension #255
Conversation
|
Thank you! Looks nice on a first check, I want to get this merged. But this PR has a lot of commits and merge commits in history. Any chance you could rebase your branch on my master and the submit your changes as a single commit instead? |
|
I also realized (after submitting the PR) that I should also update some of the GUI figures to show the new fields. So I'll make these updates and then re-submit the PR and squash the commits. |
EigenMania
force-pushed
the
feature/apply_pretension
branch
2 times, most recently
from
cbd3b5c to
e4efd94
Compare
|
Rebased and squashed :) |
|
Thanks for doing this gentlemen! 😊 Can't wait to update! 😁 |
|
Is there already a finished version available for download? |
pretension speed cutoff configurable via GUI with units small fixes and cleanup double default speed for pretension feature for safety fix compile error and pre-compute pretension cutoff speed in init require use of speed sensor for pretension feature update readme with new screenshot of config tool fix line endings in app.c fix line endings in Configuration.cs fixed line endings in SystemView.xaml
EigenMania
force-pushed
the
feature/apply_pretension
branch
from
93c0242 to
1839259
Compare
|
Fixed some issues with line endings, now the diff should be easier to review. Some files (like SystemView.xaml) use the Unix standard with LF, while most others follow the DOS standard with CRLF, and this caused a bit of a mess at some point. |
|
Hello gentlemen, any updates yet? |
Pretension feature, since many users keep asking for it. When enabled, a constant current of 1% is applied when above a configured road-speed. Speed sensor necessary to use the feature. Can be enabled and disabled from the GUI.