MQTT interface changed #117
Open
+516
−212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yuhu-
commented
Mar 23, 2025
•
yuhu-
commented
- Unique ID for MQTT messages added
- MQTT HA device configuration added
- MQTT description added to README
- force MQTT topics to lowercase
- ebus source address changed to lowercase
…; MQTT description added to README
|
For now, it's final. I'm just looking for typos. |
|
It's just an idea, but maybe we should change the input interface. Instead of subscribing to various subtopics (restart, list, insert, etc.), we could only subscribe to "cmd." All messages would then have to be transmitted as JSON objects with an ID. What do you think? |
|
I have no experience with designing mqtt interface but what you suggest sounds reasonable 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.