Adjust sound origin to draw sound visualizations closer to the sound …

…source
danielkrupinski · Nov 8, 2023 · af9bd51 · af9bd51
1 parent 32ec365
commit af9bd51
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -7,6 +7,7 @@ Free and open-source game hack for **Counter-Strike 2**. Compatible with the lat
 
 ## What's new
 
+* 8 November 2023 - Adjusted positions of sound visualizations to be closer to the sound source
 * 1 November 2023 - **Visualize Bomb Plant** function was added to **Sound**
 * 27 October 2023 - **Visualize Player Footsteps** function was added to **Sound**
 

diff --git a/Source/FeatureHelpers/Sound/SoundWatcher.h b/Source/FeatureHelpers/Sound/SoundWatcher.h
@@ -113,7 +113,7 @@ class SoundWatcher {
             buffer.back() = '\0';
 
             if (const auto sounds = getSoundsToAddTo(std::string_view{buffer.data()}, channel.guid))
-                sounds->addSound(PlayedSound{ .guid = channel.guid, .spawnTime = curtime, .origin = channelInfo2.memory[i].origin });
+                sounds->addSound(PlayedSound{ .guid = channel.guid, .spawnTime = curtime, .origin = correctSoundOrigin(channelInfo2.memory[i].origin) });
         }
     }
 
@@ -145,6 +145,12 @@ class SoundWatcher {
         return soundName == cs2::kBombPlantSoundPath;
     }
 
+    [[nodiscard]] static cs2::Vector correctSoundOrigin(cs2::Vector origin) noexcept
+    {
+        constexpr auto heightDifference = -18.0f;
+        return cs2::Vector{ origin.x, origin.y, origin.z + heightDifference };
+    }
+
     cs2::SoundChannels** soundChannels{ SoundSystemPatterns::soundChannels() };
     cs2::CBaseFileSystem** fileSystem{ FileSystemPatterns::fileSystem() };
     GlobalVarsProvider globalVarsProvider;

diff --git a/Source/Features/Sound/BombPlantVisualizer.h b/Source/Features/Sound/BombPlantVisualizer.h
@@ -122,7 +122,7 @@ class BombPlantVisualizer : public TogglableFeature<BombPlantVisualizer> {
                 R"(
 (function() {
 var bombPlantPanel = $.CreatePanel('Panel', $.GetContextPanel().FindChildInLayoutFile("BombPlantContainer"), '', {
-  style: 'width: 100px; height: 100px; x: -50px; y: -50px;'
+  style: 'width: 100px; height: 100px; x: -50px; y: -100px; transform-origin: 50% 100%;'
 });
 
 $.CreatePanel('Image', bombPlantPanel, '', {

diff --git a/Source/Features/Sound/FootstepVisualizer.h b/Source/Features/Sound/FootstepVisualizer.h
@@ -123,7 +123,7 @@ class FootstepVisualizer : public TogglableFeature<FootstepVisualizer> {
                 R"(
 (function() {
 var footstepPanel = $.CreatePanel('Panel', $.GetContextPanel().FindChildInLayoutFile("FootstepContainer"), '', {
-  style: 'width: 50px; height: 50px; x: -25px; y: -25px;'
+  style: 'width: 50px; height: 50px; x: -25px; y: -50px; transform-origin: 50% 100%;'
 });
 
 $.CreatePanel('Image', footstepPanel, '', {