Code

Tillotson cleanup and testing#609

Code

Merged

danieljprice merged 74 commits intomasterdanieljprice/phantom:masterfrom tillotsondanieljprice/phantom:tillotsonCopy head branch name to clipboardDec 20, 2024

+1,585-673

Commits

Commits on Aug 7, 2024

• (tillotson) added module and subroutines for tillotson eos

  Ambionce

  committed
  4303043

  Copy full SHA for 4303043

• merge

  Ambionce

  committed
  7131412

  Copy full SHA for 7131412

Commits on Aug 12, 2024

• (Tillotson) wrote psuedocode for EOS

  Ambionce

  committed
  ea43d24

  Copy full SHA for ea43d24

• (units) added earth radii to unit options

  Ambionce

  committed
  91c9f0d

  Copy full SHA for 91c9f0d

• (units) added earth radii to unit options

  Ambionce

  committed
  9db149c

  Copy full SHA for 9db149c

Commits on Aug 13, 2024

• (tillotson) added psuedocode - tillotson eos parameters for basalt and ice

  Ambionce

  committed
  c8c7280

  Copy full SHA for c8c7280

Commits on Aug 14, 2024

• (tillotson) compiled code and params for basalt from benz & asphaug 1999

  Ambionce

  committed
  93466fa

  Copy full SHA for 93466fa

Commits on Aug 15, 2024

• (tillotson) added initialise eos case 23 subroutine

  Ambionce

  committed
  665fcb3

  Copy full SHA for 665fcb3

• (tillotson) update init and read eos subroutines for case 23

  Ambionce

  committed
  00c42fe

  Copy full SHA for 00c42fe

• (tillotson) updated eos and readwrite infile to include case 23 eos

  Ambionce

  committed
  bf14df6

  Copy full SHA for bf14df6

Commits on Aug 17, 2024

• (tillotson) remove unit conversion from write options eos

  Ambionce

  committed
  03f8493

  Copy full SHA for 03f8493

Commits on Aug 20, 2024

• (setup_solarsystem) added mass of sun in binary system setup

  Ambionce

  committed
  cd8df39

  Copy full SHA for cd8df39

• (setup_binary) removed hardcoded eos in subroutine

  Ambionce

  committed
  0a5f901

  Copy full SHA for 0a5f901

Commits on Aug 21, 2024

• (tillotson) fixed units read-write functions and updated condensed-evaporated cases

  Ambionce

  committed
  19a988b

  Copy full SHA for 19a988b

Commits on Sep 3, 2024

• (tillotson) added calculation of temp to internal energy to eos subroutine call

  Ambionce

  committed
  14b9bc2

  Copy full SHA for 14b9bc2

• (solarsystem) included asteroid apophis into ephemeris and solarsystem setup

  Ambionce

  committed
  5063782

  Copy full SHA for 5063782

Commits on Sep 6, 2024

• Merge remote-tracking branch 'origin' into Tillotson

  Show description for 73c34cb
  Ambionce

  committed
  73c34cb

  Copy full SHA for 73c34cb

Commits on Sep 10, 2024

• (tillotson) fix windows crap

  Ambionce

  committed
  03b50a9

  Copy full SHA for 03b50a9

Commits on Sep 11, 2024

• (solarsystem) initial change from multiple binary setups to single star with particles setup

  Ambionce

  committed
  db69327

  Copy full SHA for db69327

Commits on Sep 13, 2024

• (tillotson) update eos to include hybrid phase and fix greek parameter errors

  Ambionce

  committed
  a7ad58f

  Copy full SHA for a7ad58f

• (tillotson) updated internal energy calculation

  Ambionce

  committed
  40d7cb2

  Copy full SHA for 40d7cb2

Commits on Sep 16, 2024

• (tillotson) updated pressure and energy conditional calculations

  Ambionce

  committed
  fa0b709

  Copy full SHA for fa0b709

Commits on Sep 18, 2024

• (tillotson) quadratic equation fix for internal energy subroutine

  Ambionce

  committed
  4eec9e7

  Copy full SHA for 4eec9e7

• (tillotson) in Makefile changed order for reading in cubicsolve

  Ambionce

  committed
  211829a

  Copy full SHA for 211829a

Commits on Sep 20, 2024

• (tillotson) update piecewise pressure and internal energy

  Ambionce

  committed
  3bf2555

  Copy full SHA for 3bf2555

Commits on Sep 24, 2024

• (tillotson) add calc u from prho to testing suite

  Ambionce

  committed
  47d5663

  Copy full SHA for 47d5663

• Merge branch 'danieljprice:master' into Tillotson

  AmberTilly

  authored
  56d18c4

  Copy full SHA for 56d18c4

• (tillotson) removed unnecessary code

  Ambionce

  committed
  e3091aa

  Copy full SHA for e3091aa

Commits on Oct 1, 2024

• (Tillotson) updated eos piecewise and testing of eos

  Ambionce

  committed
  6e4764f

  Copy full SHA for 6e4764f

Commits on Oct 4, 2024

• (tillotson) fixed piecewise eos to within 1.E-12 tol

  Ambionce

  committed
  5034e52

  Copy full SHA for 5034e52

Commits on Oct 9, 2024

• (tillotson) removed low energy cold expansion state as negative pressures ensue

  Ambionce

  committed
  f59bfd1

  Copy full SHA for f59bfd1

Commits on Oct 13, 2024

• (tillotson) update set star utils and eos to ensure zero initial internal energy

  Ambionce

  committed
  8318ad2

  Copy full SHA for 8318ad2

Commits on Dec 2, 2024

• Merge branch 'danieljprice:master' into Tillotson

  AmberTilly

  authored
  b3ea73e

  Copy full SHA for b3ea73e

Commits on Dec 15, 2024

• (solarsystem) new add_body routine, also set planet accretion radii from their actual radii in JPL data files

  danieljprice

  committed
  4ef899b

  Copy full SHA for 4ef899b

• merge master->tillotson

  danieljprice

  committed
  b87588b

  Copy full SHA for b87588b

• (tillotson) cleanup compiler warnings and unused functionality

  danieljprice

  committed
  0936cc5

  Copy full SHA for 0936cc5

Commits on Dec 16, 2024

• (test_eos) cleanup of test_u_from_Prho; apply to as many eos types as possible

  danieljprice

  committed
  af519b0

  Copy full SHA for af519b0

• (tillotson) cleanup/rewrite of tillotson eos routines

  danieljprice

  committed
  49643f1

  Copy full SHA for 49643f1

• (test_eos) added test_all routine to check for continuous pressure in all eos routines; added helper function to avoid modifying readwrite_infile; remove ifdefs #55

  danieljprice

  committed
  feb54f5

  Copy full SHA for feb54f5

• (test_eos) check eos is continuous with rho and u

  danieljprice

  committed
  57c9f27

  Copy full SHA for 57c9f27

• (tillotson) cleanup and further testing

  danieljprice

  committed
  9e4087f

  Copy full SHA for 9e4087f

• (test_eos) skip ieos=21,22 in continuity-of-pressure test

  danieljprice

  committed
  660e1dc

  Copy full SHA for 660e1dc

• [header-bot] updated file headers

  danieljprice

  committed
  9b37de2

  Copy full SHA for 9b37de2

• [space-bot] whitespace at end of lines removed

  danieljprice

  committed
  34cb52a

  Copy full SHA for 34cb52a

• [author-bot] updated AUTHORS file

  danieljprice

  committed
  60e64d2

  Copy full SHA for 60e64d2

• [format-bot] end if -> endif; end do -> enddo; if( -> if (

  danieljprice

  committed
  1a66e9c

  Copy full SHA for 1a66e9c

• [indent-bot] standardised indentation

  danieljprice

  committed
  e1ff4e8

  Copy full SHA for e1ff4e8

• (docs) update documentation

  danieljprice

  committed
  a8e77a2

  Copy full SHA for a8e77a2

• merge conflict fixed

  danieljprice

  committed
  efb71b6

  Copy full SHA for efb71b6

Commits on Dec 18, 2024

• (test_eos) fix test failure due to uninitialised variable

  danieljprice

  committed
  f4f35a6

  Copy full SHA for f4f35a6

• (tillotson) update docs with eos details

  danieljprice

  committed
  a6be532

  Copy full SHA for a6be532

• (solarsystem) cleanup functionality into set_bodies module; add options for minor bodies, planets etc, add option for epoch when retrieving ephemeris, fix bugs in ephemeris read

  danieljprice

  committed
  77f10e6

  Copy full SHA for 77f10e6

• (checksetup) check for NaNs in sink particle arrays

  danieljprice

  committed
  ca78095

  Copy full SHA for ca78095

• (utils_dumpfiles) out of bounds error fixed if there are no SPH particles

  danieljprice

  committed
  0231c97

  Copy full SHA for 0231c97

• (substep) do not call update_ptmass if nothing has been accreted; also handle case where sink mass is initially zero

  danieljprice

  committed
  ac0777a

  Copy full SHA for ac0777a

• (checksetup) seg fault fixed from apr stuff left in checksetup routine

  danieljprice

  committed
  71f8203

  Copy full SHA for 71f8203

• (solarsystem) working simulation of impending destruction

  danieljprice

  committed
  d2dc2bf

  Copy full SHA for d2dc2bf

• (ephemeris) added setup for dwarf planets

  danieljprice

  committed
  f2847e5

  Copy full SHA for f2847e5

• (test_eos) compiler warning fixed

  danieljprice

  committed
  376a98e

  Copy full SHA for 376a98e

• (solarsystem) add gravity, option for number of particles in body

  danieljprice

  committed
  f72d676

  Copy full SHA for f72d676

Commits on Dec 19, 2024

• (eos) added eos_requires_polyk routine instead of hardwiring eos options in checksetup routine; also fix accounting in identical positions check

  danieljprice

  committed
  a3f0aec

  Copy full SHA for a3f0aec

• (setup) bug fixed in setup; use closepacked lattice; nptot no longer optional in call to set_sphere to avoid seg fault

  danieljprice

  committed
  6110247

  Copy full SHA for 6110247

• (set_sphere) test failures fixed

  danieljprice

  committed
  7948ddc

  Copy full SHA for 7948ddc

Commits on Dec 20, 2024

• (test_ptmass) bug fix with previous fix for zero-mass sinks; tighten tolerances in disc tests

  danieljprice

  committed
  c003cb6

  Copy full SHA for c003cb6

• (test_ptmass) revert changes to tolerances

  danieljprice

  committed
  8cdebf8

  Copy full SHA for 8cdebf8

• (eos) tillotson outputs pressure to dump file

  danieljprice

  committed
  02fd8ec

  Copy full SHA for 02fd8ec

• (apr) bug fix with mpi_dens extent calculation; also make this a fatal error so it flags in test suite

  danieljprice

  committed
  1854e41

  Copy full SHA for 1854e41

• (ptmass) fix test failure with MPI

  danieljprice

  committed
  542f401

  Copy full SHA for 542f401

• (mpi) added bcast_mpi_logical routine

  danieljprice

  committed
  7d9ff16

  Copy full SHA for 7d9ff16

• (test_ptmass) BUG FIX with epot_sinksink causing test failure with MPI in ptmassSDAR test; single values now correctly reduced across mpi threads in the checkval routine

  danieljprice

  committed
  ef9b449

  Copy full SHA for ef9b449

• (header) amend header to reflect collaborative authorship of Phantom

  danieljprice

  committed
  0ccbae3

  Copy full SHA for 0ccbae3

• (mpi) test failure fixed

  danieljprice

  committed
  ee1e177

  Copy full SHA for ee1e177

• (mpi) hangs in testsuite with checks on single thread fixed

  danieljprice

  committed
  8905290

  Copy full SHA for 8905290

• (build) build failures fixed

  danieljprice

  committed
  34c4792

  Copy full SHA for 34c4792