fix: wait properly for avatar cache to be evicted

close #73
daniele-athome · Aug 14, 2023 · c5d6b2a · c5d6b2a
1 parent 0c07018
commit c5d6b2a
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 13 deletions.
diff --git a/lib/helpers/config.dart b/lib/helpers/config.dart
@@ -20,7 +20,7 @@ class AppConfig extends ChangeNotifier {
       // load current aircraft
       try {
         final aircraftReader = await loadAircraft(_currentAircraftId!);
-        currentAircraft = aircraftReader.toAircraftData();
+        await setCurrentAircraft(aircraftReader.toAircraftData());
       } catch (e) {
         _log.info('Error loading current aircraft, cleaning everything ($e)');
         _currentAircraftId = null;
@@ -147,7 +147,7 @@ class AppConfig extends ChangeNotifier {
 
   AircraftData? get currentAircraft => _currentAircraft;
 
-  set currentAircraft(AircraftData? data) {
+  Future<void> setCurrentAircraft(AircraftData? data) async {
     if (data != null) {
       _log.fine('Switching aircraft: ${data.callSign}');
     } else {
@@ -192,10 +192,10 @@ class AppConfig extends ChangeNotifier {
     notifyListeners();
   }
 
-  void _clearPictureCache() {
-    aircraftPicture.evict();
+  void _clearPictureCache() async {
+    await aircraftPicture.evict();
     for (var name in pilotNames) {
-      getPilotAvatar(name).evict();
+      await getPilotAvatar(name).evict();
     }
   }
 }
diff --git a/lib/screens/about/about_screen.dart b/lib/screens/about/about_screen.dart
@@ -54,8 +54,8 @@ class _AboutScreenState extends State<AboutScreen> {
         final userpass = value[0];
         final downloadTask = downloadAircraftData(
                 _appConfig.currentAircraft!.url!, userpass, _downloadProvider)
-            .then<AircraftData?>((AircraftData aircraftData) {
-          _appConfig.currentAircraft = aircraftData;
+            .then<AircraftData?>((AircraftData aircraftData) async {
+          await _appConfig.setCurrentAircraft(aircraftData);
           _appConfig.updateAircraft(aircraftData);
           return aircraftData;
         }).catchError((error, StackTrace? stacktrace) {
@@ -106,9 +106,10 @@ class _AboutScreenState extends State<AboutScreen> {
       destructiveOk: true,
       okCallback: () {
         _appConfig.pilotName = null;
-        _appConfig.currentAircraft = null;
-        Navigator.of(context, rootNavigator: true)
-            .popAndPushNamed('aircraft-data');
+        _appConfig.setCurrentAircraft(null).whenComplete(() {
+          Navigator.of(context, rootNavigator: true)
+              .popAndPushNamed('aircraft-data');
+        });
       },
     );
   }

diff --git a/lib/screens/aircraft_select/aircraft_data_screen.dart b/lib/screens/aircraft_select/aircraft_data_screen.dart
@@ -77,8 +77,8 @@ class _SetAircraftDataScreenState extends State<SetAircraftDataScreen> {
 
       final downloadTask = downloadAircraftData(
               _aircraftUrl!, _aircraftPassword, downloadProvider)
-          .then<AircraftData?>((AircraftData aircraftData) {
-        appConfig.currentAircraft = aircraftData;
+          .then<AircraftData?>((AircraftData aircraftData) async {
+        await appConfig.setCurrentAircraft(aircraftData);
         appConfig.addAircraft(aircraftData);
         return aircraftData;
       }).catchError((error, StackTrace? stacktrace) {

diff --git a/screenshots/fake_data.dart b/screenshots/fake_data.dart
@@ -239,7 +239,7 @@ class FakeAppConfig extends AppConfig {
     );
     await reader.open();
 
-    currentAircraft = reader.toAircraftData();
+    await setCurrentAircraft(reader.toAircraftData());
   }
 
 }