Sourcery refactored master branch #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-67
to
+75
|
|
||
| if 'id_token' in response_json: | ||
| if response_json['id_token'] is not None: | ||
| is_valid = validate_id_token(response_json['id_token'], obj.client_id, obj.issuer_uri, obj.jwks_uri) | ||
| if is_valid: | ||
| obj.id_token = response_json['id_token'] | ||
|
|
||
| if 'id_token' in response_json and response_json['id_token'] is not None: | ||
| if is_valid := validate_id_token( | ||
| response_json['id_token'], | ||
| obj.client_id, | ||
| obj.issuer_uri, | ||
| obj.jwks_uri, | ||
| ): | ||
| obj.id_token = response_json['id_token'] |
There was a problem hiding this comment.
Function set_attributes refactored with the following changes:
- Merge nested if conditions (
merge-nested-ifs) - Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-139
to
+142
| return ''.join(random.choice(allowed_chars) for i in range(length)) | ||
| return ''.join(random.choice(allowed_chars) for _ in range(length)) |
There was a problem hiding this comment.
Function generate_token refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
Comment on lines
-159
to
+175
| if id_token_payload['iss'] != intuit_issuer: | ||
| if ( | ||
| id_token_payload['iss'] != intuit_issuer | ||
| or id_token_payload['aud'][0] != client_id | ||
| ): | ||
| return False | ||
| elif id_token_payload['aud'][0] != client_id: | ||
| return False | ||
|
|
||
| current_time = (datetime.utcnow() - datetime(1970, 1, 1)).total_seconds() | ||
| if id_token_payload['exp'] < current_time: | ||
| return False | ||
|
|
||
| message = id_token_parts[0] + '.' + id_token_parts[1] | ||
| message = f'{id_token_parts[0]}.{id_token_parts[1]}' | ||
| keys_dict = get_jwk(id_token_header['kid'], jwk_uri) | ||
|
|
||
| public_key = jwk.construct(keys_dict) | ||
| is_signature_valid = public_key.verify(message.encode('utf-8'), id_token_signature) | ||
| return is_signature_valid | ||
| return public_key.verify(message.encode('utf-8'), id_token_signature) |
There was a problem hiding this comment.
Function validate_id_token refactored with the following changes:
- Merge duplicate blocks in conditional (
merge-duplicate-blocks) - Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Inline variable that is immediately returned (
inline-immediately-returned-variable) - Remove redundant conditional (
remove-redundant-if)
Comment on lines
-189
to
+191
| keys = next(key for key in data["keys"] if key['kid'] == kid) | ||
| return keys | ||
| return next(key for key in data["keys"] if key['kid'] == kid) |
There was a problem hiding this comment.
Function get_jwk refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.59%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!